Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 15 Dec 2019 03:54:27 +0000
From:      bugzilla-noreply@freebsd.org
To:        gnome@FreeBSD.org
Subject:   [Bug 237822] x11-toolkits/pango: Fails to configure with DOCS=ON X11=OFF: ERROR: Unknown variable "xft_dep". (since 1.42.4_2, ports r500960)
Message-ID:  <bug-237822-6497-7ULrk5ASx5@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-237822-6497@https.bugs.freebsd.org/bugzilla/>
References:  <bug-237822-6497@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D237822

--- Comment #44 from John Hein <jcfyecrayz@liamekaens.com> ---
Created attachment 209962
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D209962&action=
=3Dedit
[patch] improve docs/meson.build

The patch (attachment 205022) is not quite right.  See also comment 29.

It passes the wrong list to the gtkdoc-scan --ignore-headers option when
DOCS=3Don and X11=3Don (it should not ignore the xft header files - i.e., i=
t should
not add them to "private_headers" in the meson.build file).

Attached is a better patch that fixes that.  When building with DOCS and X11
on, docs/meson.build should not set the xft headers as "private" (which mea=
ns
that they are added to --ignore-headers when gtkdoc-scan is called).

I discovered this around the end of Nov. but didn't have time to fix up a
correct patch and submit here at the time.  @swills, sorry I didn't get to =
it
before you committed r519952.

This new patch has been tested with DOCS on/off, X11 on/off in poudriere.  =
It
fixes all the configure, link problems (which no longer occur after r519952=
),
and also fixes the generated docs as well.

This patch is generated against the r519952 version.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-237822-6497-7ULrk5ASx5>