From owner-freebsd-ports@FreeBSD.ORG  Mon Jun 11 22:20:47 2012
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 8D9031065672;
	Mon, 11 Jun 2012 22:20:47 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 8DAE48FC14;
	Mon, 11 Jun 2012 22:20:46 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
	[212.40.38.100])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id BAA02679;
	Tue, 12 Jun 2012 01:20:45 +0300 (EEST)
	(envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
	by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
	id 1SeCya-0003x6-QR; Tue, 12 Jun 2012 01:20:44 +0300
Message-ID: <4FD66F3B.7070306@FreeBSD.org>
Date: Tue, 12 Jun 2012 01:20:43 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:12.0) Gecko/20120503 Thunderbird/12.0.1
MIME-Version: 1.0
To: FreeBSD Ports <ports@FreeBSD.org>, kde@FreeBSD.org
X-Enigmail-Version: 1.5pre
Content-Type: text/plain; charset=X-VIET-VPS
Content-Transfer-Encoding: 7bit
Cc: 
Subject: graphics/djview4: QMAKESPEC override?
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jun 2012 22:20:47 -0000


Writing to both a formal maintainer and a more realistic maintainer.
graphics/djview4 Makefile has this:
.if defined(CXX) && ${CXX:M*icc}
QMAKESPEC?=     freebsd-icc
.else
QMAKESPEC?=    freebsd-g++
.endif

This snippet is before bsd.port.pre.mk inclusion.  Thus, it overrides the logic
for QMAKESPEC selection in bsd.qt.mk for no apparent good reason.

Removing it doesn't break anything and fixes compilation with gcc46 too.

P.S.  Does anyone actually uses icc on FreeBSD to build ports?  I doubt that
very much.

-- 
Andriy Gapon