Date: Mon, 18 Feb 2002 13:16:28 -0500 (EST) From: Robert Watson <rwatson@FreeBSD.ORG> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: Poul-Henning Kamp <phk@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern kern_time.c Message-ID: <Pine.NEB.3.96L.1020218131043.69361v-100000@fledge.watson.org> In-Reply-To: <200202181806.g1II6de26559@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 18 Feb 2002, Matthew Dillon wrote:
> Again, I will repeat: JOHN HAS PATCHES STREWN ALL OVER THE FRAGGIN
> SYSTEM THAT HAVEN'T BEEN COMMITTED. Unless you are proposing that
> we all throw up our hands and just wait for John to essentially do
> all the SMP work in the entire system for the next year, I am not going
> to wait.
Matt,
No one is suggesting that. I'm suggesting that you talk with John before
committing so that:
(1) You don't duplicate work he has already done, and has in the commit
queue, which he hasn't committed specifically because the pieces
weren't there.
(2) You don't cause unnecessary hassle for John from conflicts.
I'm not saying "wait until next year", I'm saying "Wait until Tuesday".
If you feel this can't wait two days, then you need to take a deep breath,
and step away from the keyboard for a few minutes.
> I am here now. I have tested, working patches now, relative to the
> latest current and Julian's stuff. I am committing them now.
>
> If John has issues he can email me and we will work it out. Frankly, I
> am just continuing the Giant pushdown work I started a few months ago in
> kern_prot.c. Who the hell do you think pushed Giant into these routines
> from the syscall wrapper in the first place?
Basic coordination and interaction skills are required to work on this
project. That means sometimes not committing the moment the patch is
ready so that you can talk about it with others.
Here are the changes I have no problem with you committing:
(1) Pushing the acquisition of Giant into individual system calls rather
than relying on the system call wrapper. This is in line with the
previous commits you have made.
Here are the changes that I do not want you to commit without advance
coordination with John:
(1) Changing from p_ucred to td_ucred
(2) Changes from using Giant to other locks within the credential-related
calls
(3) Changes that conflict with or duplicate the changes in John's proc
locking tree.
Robert N M Watson FreeBSD Core Team, TrustedBSD Project
robert@fledge.watson.org NAI Labs, Safeport Network Services
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1020218131043.69361v-100000>