From owner-cvs-src@FreeBSD.ORG Wed Mar 23 21:44:03 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8740916A4CE; Wed, 23 Mar 2005 21:44:03 +0000 (GMT) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id D900D43D1F; Wed, 23 Mar 2005 21:44:02 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.34] (adsl-67-119-74-222.dsl.sntc01.pacbell.net [67.119.74.222]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j2NLfnZj024702 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 23 Mar 2005 13:41:50 -0800 Message-ID: <4241E29C.7010407@root.org> Date: Wed, 23 Mar 2005 13:41:48 -0800 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Warner Losh References: <1111516858.1198.2.camel@localhost> <424079AB.6050805@root.org> <1111611460.1805.1.camel@localhost> <20050323.143742.74706153.imp@bsdimp.com> In-Reply-To: <20050323.143742.74706153.imp@bsdimp.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: vova@fbsd.ru cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/acpica acpi_perf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2005 21:44:03 -0000 Warner Losh wrote: >>>Ok, I've committed a fix: acpi.c rev 1.207. Please cvsup and test. >> >>It does not help, still same panic > > > It doesn't help me either, and an audit of the code suggests that it > will have no effect. There's a resource that's marked as being > active, which is why the panic is happening.... I've always hated > these panics, but have appreciated them in hindsight once the bug has > been fixed because it is a very effective enforcement of proper > operations. > > Warner I'm trying to figure out what's going on. The probe routine should not be called multiple times since it returns 0 and now with my commit it should completely clean up after itself. Can you put this in acpi_perf_identify, probe, attach and let me know the full dmesg up to the panic? printf("%s called\n", __func__); -- Nate