From owner-freebsd-hackers Thu Feb 2 03:44:09 1995 Return-Path: hackers-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.9/8.6.6) id DAA01226 for hackers-outgoing; Thu, 2 Feb 1995 03:44:09 -0800 Received: from wcarchive.cdrom.com (wcarchive.cdrom.com [192.216.191.11]) by freefall.cdrom.com (8.6.9/8.6.6) with ESMTP id DAA01220 for ; Thu, 2 Feb 1995 03:44:07 -0800 Received: from UUCP-GW.CC.UH.EDU (root@UUCP-GW.CC.UH.EDU [129.7.1.11]) by wcarchive.cdrom.com (8.6.8/8.6.6) with SMTP id DAA08851 for ; Thu, 2 Feb 1995 03:43:52 -0800 Received: from Taronga.COM by UUCP-GW.CC.UH.EDU with UUCP id AA26534 (5.67a/IDA-1.5); Thu, 2 Feb 1995 05:14:20 -0600 Received: by bonkers.taronga.com (smail2.5p) id AA11161; 2 Feb 95 05:12:33 CST (Thu) Received: from localhost (localhost [127.0.0.1]) by bonkers.taronga.com (8.6.8/8.6.6) with SMTP id FAA11158; Thu, 2 Feb 1995 05:12:32 -0600 Message-Id: <199502021112.FAA11158@bonkers.taronga.com> X-Authentication-Warning: bonkers.taronga.com: Host localhost didn't use HELO protocol To: Thomas David Rivers Cc: freebsd-hackers@wcarchive.cdrom.com, longyear@netcom.com, rivers@dg-rtp.dg.com Subject: Re: chat(8) improvements for SL/IP dialout. In-Reply-To: Your message of "Wed, 01 Feb 95 21:03:39 EST." <199502020203.VAA01811@ponds.UUCP> X-Mailer: exmh version 1.4.1 7/21/94 Date: Thu, 02 Feb 1995 05:12:29 -0600 From: Peter da Silva Sender: hackers-owner@FreeBSD.org Precedence: bulk Looks nifty. One point: > t.c_lflag = 0; > + if(command) { > + /* If we're going to execute a command, don't hang-up */ > + /* the device when we're done. */ > + t.c_cflag &= ~HUPCL; > + } > t.c_cc[VERASE] = t.c_cc[VKILL] = 0; Why not? Oh, for SLIP or PPP where the command just establishes a connection that's useful, but for a situation where you're running some conventional command (like, say, a dialback security mechanism) you want to retain HUPCL. I'd say make this a separate option, or even better have an optional set of stty arguments to apply to the port (including baud rate, which you can pre- parse to set up before calling stty and the command). (pppd is already set up to call chat itself. I'm sorta surprised slip doesn't do that...)