From owner-p4-projects@FreeBSD.ORG  Tue Jul 22 17:49:02 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4F5F8106567B; Tue, 22 Jul 2008 17:49:02 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 12D7A1065676
	for <perforce@freebsd.org>; Tue, 22 Jul 2008 17:49:02 +0000 (UTC)
	(envelope-from trasz@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 081088FC0A
	for <perforce@freebsd.org>; Tue, 22 Jul 2008 17:49:02 +0000 (UTC)
	(envelope-from trasz@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m6MHn1v9007772
	for <perforce@freebsd.org>; Tue, 22 Jul 2008 17:49:01 GMT
	(envelope-from trasz@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.2/8.14.1/Submit) id m6MHn1e2007770
	for perforce@freebsd.org; Tue, 22 Jul 2008 17:49:01 GMT
	(envelope-from trasz@freebsd.org)
Date: Tue, 22 Jul 2008 17:49:01 GMT
Message-Id: <200807221749.m6MHn1e2007770@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	trasz@freebsd.org using -f
From: Edward Tomasz Napierala <trasz@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 145639 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Jul 2008 17:49:02 -0000

http://perforce.freebsd.org/chv.cgi?CH=145639

Change 145639 by trasz@trasz_traszkan on 2008/07/22 17:48:59

	File owner should be implicitly granted ACL_READ_ATTRIBUTES
	and ACL_WRITE_ATTRIBUTES.

Affected files ...

.. //depot/projects/soc2008/trasz_nfs4acl/sys/kern/subr_acl_nfs4.c#9 edit

Differences ...

==== //depot/projects/soc2008/trasz_nfs4acl/sys/kern/subr_acl_nfs4.c#9 (text+ko) ====

@@ -167,10 +167,12 @@
 		is_directory = 0;
 
 	/*
-	 * File owner is always allowed to read and write the ACL.
+	 * File owner is always allowed to read and write the ACL
+	 * and basic attributes.
 	 */
 	if (file_uid == cred->cr_uid)
-		needed_bits &= ~(ACL_READ_ACL | ACL_WRITE_ACL);
+		needed_bits &= ~(ACL_READ_ACL | ACL_WRITE_ACL |
+		    ACL_READ_ATTRIBUTES | ACL_WRITE_ATTRIBUTES);
 
 	denied = _match_acl(aclp, needed_bits, cred, file_uid, file_gid);
 	if (!denied)