From owner-svn-ports-head@FreeBSD.ORG  Tue May 13 21:12:50 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 4F117805;
 Tue, 13 May 2014 21:12:50 +0000 (UTC)
Received: from mail.feld.me (mail.feld.me [66.170.3.6])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "mail.feld.me", Issuer "Gandi Standard SSL CA" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id C79DA2F34;
 Tue, 13 May 2014 21:12:49 +0000 (UTC)
Received: from mail.feld.me (mail.feld.me [66.170.3.6]);
 by mail.feld.me (OpenSMTPD) with ESMTP id bf8b098b;
 Tue, 13 May 2014 16:12:39 -0500 (CDT)
Received: from feld@feld.me by mail.feld.me (Archiveopteryx 3.2.0) with
 esmtpa id 1400015558-9678-9675/5/1; Tue, 13 May 2014 21:12:38 +0000
Content-Type: text/plain
Mime-Version: 1.0
Subject: Re: svn commit: r353977 - head/security/py-fail2ban
From: Mark Felder <feld@FreeBSD.org>
In-Reply-To: <201405131830.s4DIUNGm023128@svn.freebsd.org>
Date: Tue, 13 May 2014 16:12:36 -0500
Content-Transfer-Encoding: quoted-printable
Message-Id: <5CC317FA-F4BD-40C4-ACD8-04AB16902C4A@FreeBSD.org>
References: <201405131830.s4DIUNGm023128@svn.freebsd.org>
To: Adam Weinberger <adamw@FreeBSD.org>
X-Mailer: Apple Mail (2.1874)
Sender: feld@feld.me
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@FreeBSD.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 13 May 2014 21:12:50 -0000


On May 13, 2014, at 13:30, Adam Weinberger <adamw@FreeBSD.org> wrote:

>=20
> post-install:
> -	@${MKDIR} ${STAGEDIR}${FAIL2BAN_DBDIR}
> +	@${MKDIR} ${STAGEDIR}${FAIL2BAN_DBDIR} ${STAGEDIR}/var/run/fail2ban
> 	@${MKDIR} ${STAGEDIR}${DOCSDIR}
> 	(cd ${WRKSRC}/ && ${INSTALL_DATA} ${PORTDOCS} ${STAGEDIR}${DOCSDIR})
> .for file in fail2ban-client fail2ban-regex fail2ban-server fail2ban
>=20


Pkg ignores items in ${STAGEDIR}/var (and probably all of base), so this =
won't actually make it into a package. In fact, since the creation of =
the stage dir it won't even make it if installed from a port (as a =
package is created before being installed). Anything you need created =
for the port to run that must exist in base such as /var/run/, /var/db/, =
/var/log/, etc should be handled in the rc script start_precmd so it =
gets created if necessary just before the daemon is launched.

Just drop something in like

start_precmd=3Dfail2ban_prestart

fail2ban_prestart()
{
    for i in run db; do
        if [ ! -d /var/${i}/fail2ban ]; then
          install -d -o fail2ban /dev/null /var/${i}/fail2ban
        fi
    done
}

(or more verbose, but two actions -- mkdir and then chown)

and then you can remove those MKDIRs in post-install


hth