Date: Thu, 27 Oct 2022 22:33:57 +0000 From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: [Bug 267393] net-im/libnice: Add GNUTLS option Message-ID: <bug-267393-6497-qlVbtnt6u2@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-267393-6497@https.bugs.freebsd.org/bugzilla/> References: <bug-267393-6497@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D267393 --- Comment #2 from Kubilay Kocak <koobs@FreeBSD.org> --- Thank you for the patch Jonathan. Some review items: 1) The build should be tested in these cases: - GNUTLS=3DOFF and - gnutls (only) is installed (not via *_DEPENDS) - openssl (only) is installed (not via *_DEPENDS) - gnutls (and) openssl are installed (not via *_DEPENDS) 2) Consider An SSL library group with two mutually exclusive options, one GNUTLS the other OPENSSL Note: This can either be in the form of - OPTIONS_SINGLE (one choice *must* be selected) - OPTIONS_RADIO (none or one choice can be selected) If libnice supports a build configuration without ssl library support at al= l, OPTIONS_RADIO is more appropriate. If not, OPTIONS_SINGLE is the way to go 3) The current port Makefile doesn't set USES=3Dssl. In the case where GNUTLS=3DOFF, or the grouped option OPENSSL is selected, it should probably= use USES=3Dssl[:...] with appropriate variables from that file. --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-267393-6497-qlVbtnt6u2>