From owner-svn-src-head@FreeBSD.ORG Tue Mar 6 08:57:30 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F0319106567D; Tue, 6 Mar 2012 08:57:30 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 30E5D8FC14; Tue, 6 Mar 2012 08:57:29 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q268vNDB066742; Tue, 6 Mar 2012 10:57:23 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q268vNXg094911; Tue, 6 Mar 2012 10:57:23 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q268vNdJ094910; Tue, 6 Mar 2012 10:57:23 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 6 Mar 2012 10:57:23 +0200 From: Konstantin Belousov To: Oleksandr Tymoshenko Message-ID: <20120306085723.GY75778@deviant.kiev.zoral.com.ua> References: <201203060329.q263TlLn017594@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+sXEj1HC0AeGgRD2" Content-Disposition: inline In-Reply-To: <201203060329.q263TlLn017594@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r232580 - head/lib/csu/mips X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Mar 2012 08:57:31 -0000 --+sXEj1HC0AeGgRD2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 06, 2012 at 03:29:47AM +0000, Oleksandr Tymoshenko wrote: > Author: gonzo > Date: Tue Mar 6 03:29:46 2012 > New Revision: 232580 > URL: http://svn.freebsd.org/changeset/base/232580 >=20 > Log: > - Remove NOSHARED parts since it seems to be no-op > - Call _init_tls for statically linked binaries >=20 > Modified: > head/lib/csu/mips/crt1.c >=20 > Modified: head/lib/csu/mips/crt1.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/lib/csu/mips/crt1.c Tue Mar 6 03:27:58 2012 (r232579) > +++ head/lib/csu/mips/crt1.c Tue Mar 6 03:29:46 2012 (r232580) > @@ -47,10 +47,8 @@ __FBSDID("$FreeBSD$"); > struct Struct_Obj_Entry; > struct ps_strings; > =20 > -#ifndef NOSHARED > extern int _DYNAMIC; > #pragma weak _DYNAMIC > -#endif > =20 > extern void _init(void); > extern void _fini(void); > @@ -91,10 +89,11 @@ __start(char **ap, > __progname =3D s + 1; > } > =20 > -#ifndef NOSHARED > if (&_DYNAMIC !=3D NULL) > atexit(cleanup); > -#endif > + else > + _init_tls(); > + > #ifdef GCRT > atexit(_mcleanup); > #endif Oh great. I tried to understand this bits for some time, due to init_array work, and was unable to make any sense of it. I will update the patchset to include MIPS now. --+sXEj1HC0AeGgRD2 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk9V0XIACgkQC3+MBN1Mb4gwkwCeLasAfaEpAQrVLAUhRKpBgqeL d7sAoKQNHipqeV+Ffb5YnPwOFfXlqs1Y =s7h0 -----END PGP SIGNATURE----- --+sXEj1HC0AeGgRD2--