Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 22 Oct 2012 22:14:25 +1100 (EST)
From:      Bruce Evans <brde@optusnet.com.au>
To:        Warner Losh <imp@bsdimp.com>
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Warner Losh <imp@FreeBSD.org>, Bruce Evans <brde@optusnet.com.au>
Subject:   Re: svn commit: r241755 - head/lib/msun/src
Message-ID:  <20121022213348.T1373@besplex.bde.org>
In-Reply-To: <18177777-6EE0-4103-98B0-272EFF98FE96@bsdimp.com>
References:  <201210192246.q9JMkm4R092929@svn.freebsd.org> <20121020150917.I1095@besplex.bde.org> <18177777-6EE0-4103-98B0-272EFF98FE96@bsdimp.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 21 Oct 2012, Warner Losh wrote:

> Feel free to fix them however.  I added the comments because the algorithms weren't quite the same...  If you have a better way, feel free to back my stuff out on the way to it.

But the algorithms are identical to a fault.  Inside the functions, all
lines except 1 in each correspond exactly, and the exception is a style
bug.  Only about 30 lines in each are not lexically identical.  The
non-lexical differences are for things like different magic numbers.

The old fdlibm comments aren't too careful about keeping magic numbers
out of the algorithm description so that the algorithm description is
as general as possible.  The precise magic numbers are often critical
to the details of the implementation of the algorithm but not really
to the algorithm itself.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121022213348.T1373>