From owner-svn-src-head@FreeBSD.ORG  Mon Oct 22 11:14:50 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 4D34348F;
 Mon, 22 Oct 2012 11:14:50 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from fallbackmx09.syd.optusnet.com.au
 (fallbackmx09.syd.optusnet.com.au [211.29.132.242])
 by mx1.freebsd.org (Postfix) with ESMTP id 684C58FC1C;
 Mon, 22 Oct 2012 11:14:48 +0000 (UTC)
Received: from mail34.syd.optusnet.com.au (mail34.syd.optusnet.com.au
 [211.29.133.218])
 by fallbackmx09.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
 q9MBEfY8012812; Mon, 22 Oct 2012 22:14:41 +1100
Received: from c122-106-175-26.carlnfd1.nsw.optusnet.com.au
 (c122-106-175-26.carlnfd1.nsw.optusnet.com.au [122.106.175.26])
 by mail34.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id q9MBEPcW009598
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
 Mon, 22 Oct 2012 22:14:28 +1100
Date: Mon, 22 Oct 2012 22:14:25 +1100 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Warner Losh <imp@bsdimp.com>
Subject: Re: svn commit: r241755 - head/lib/msun/src
In-Reply-To: <18177777-6EE0-4103-98B0-272EFF98FE96@bsdimp.com>
Message-ID: <20121022213348.T1373@besplex.bde.org>
References: <201210192246.q9JMkm4R092929@svn.freebsd.org>
 <20121020150917.I1095@besplex.bde.org>
 <18177777-6EE0-4103-98B0-272EFF98FE96@bsdimp.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Optus-Cloudmark-Score: 0
X-Optus-Cloudmark-Analysis: v=2.0 cv=fLlhRume c=1 sm=1 a=xI64QrV9ptIA:10
 a=kj9zAlcOel0A:10 a=PO7r1zJSAAAA:8 a=JzwRw_2MAAAA:8 a=Aet6fyW9sl8A:10
 a=9q-bG5jMhbND0eD7UJQA:9 a=CjuIK1q_8ugA:10 a=bxQHXO5Py4tHmhUgaywp5w==:117
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org, Warner Losh <imp@FreeBSD.org>,
 Bruce Evans <brde@optusnet.com.au>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Oct 2012 11:14:50 -0000

On Sun, 21 Oct 2012, Warner Losh wrote:

> Feel free to fix them however.  I added the comments because the algorithms weren't quite the same...  If you have a better way, feel free to back my stuff out on the way to it.

But the algorithms are identical to a fault.  Inside the functions, all
lines except 1 in each correspond exactly, and the exception is a style
bug.  Only about 30 lines in each are not lexically identical.  The
non-lexical differences are for things like different magic numbers.

The old fdlibm comments aren't too careful about keeping magic numbers
out of the algorithm description so that the algorithm description is
as general as possible.  The precise magic numbers are often critical
to the details of the implementation of the algorithm but not really
to the algorithm itself.

Bruce