From owner-p4-projects@FreeBSD.ORG  Sun Mar  2 07:31:46 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 6012C1065674; Sun,  2 Mar 2008 07:31:46 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 19AE91065671;
	Sun,  2 Mar 2008 07:31:46 +0000 (UTC)
	(envelope-from rermilov@team.vega.ru)
Received: from mail.vega.ru (infra.dev.vega.ru [90.156.167.14])
	by mx1.freebsd.org (Postfix) with ESMTP id C3FCF8FC1A;
	Sun,  2 Mar 2008 07:31:44 +0000 (UTC)
	(envelope-from rermilov@team.vega.ru)
Received: from [87.242.97.68] (port=52507 helo=edoofus.dev.vega.ru)
	by mail.vega.ru with esmtpsa (TLSv1:AES256-SHA:256)
	(Exim 4.68 (FreeBSD)) (envelope-from <rermilov@team.vega.ru>)
	id 1JViJQ-000BQV-Lt; Sun, 02 Mar 2008 07:08:44 +0000
Received: from edoofus.dev.vega.ru (localhost [127.0.0.1])
	by edoofus.dev.vega.ru (8.14.2/8.14.2) with ESMTP id m2278g5i065789;
	Sun, 2 Mar 2008 10:08:42 +0300 (MSK)
	(envelope-from rermilov@team.vega.ru)
Received: (from ru@localhost)
	by edoofus.dev.vega.ru (8.14.2/8.14.2/Submit) id m2278g8c065788;
	Sun, 2 Mar 2008 10:08:42 +0300 (MSK)
	(envelope-from rermilov@team.vega.ru)
X-Authentication-Warning: edoofus.dev.vega.ru: ru set sender to
	rermilov@team.vega.ru using -f
Date: Sun, 2 Mar 2008 10:08:42 +0300
From: Ruslan Ermilov <ru@FreeBSD.org>
To: John Baldwin <jhb@FreeBSD.org>
Message-ID: <20080302070842.GA65621@team.vega.ru>
References: <200802080420.m184Kvmf077416@repoman.freebsd.org>
	<200802141032.33861.jhb@freebsd.org> <47B4E0F1.6060006@FreeBSD.org>
	<200802150952.39027.jhb@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200802150952.39027.jhb@freebsd.org>
User-Agent: Mutt/1.5.17 (2007-11-01)
Cc: Kris Kennaway <kris@FreeBSD.org>,
	Perforce Change Reviews <perforce@FreeBSD.org>,
	Kip Macy <kmacy@FreeBSD.org>
Subject: Re: PERFORCE change 135010 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Mar 2008 07:31:47 -0000

Hi John,

Your patch below looks good enough for committing.

On Fri, Feb 15, 2008 at 09:52:38AM -0500, John Baldwin wrote:
> Index: kmod.mk
> ===================================================================
> RCS file: /usr/cvs/src/sys/conf/kmod.mk,v
> retrieving revision 1.221
> diff -u -r1.221 kmod.mk
> --- kmod.mk	19 Nov 2007 16:24:10 -0000	1.221
> +++ kmod.mk	15 Feb 2008 14:50:03 -0000
> @@ -428,6 +428,9 @@
>  assym.s: @/kern/genassym.sh
>  .endif
>  	sh @/kern/genassym.sh genassym.o > ${.TARGET}
> +.if defined(KERNBUILDDIR)
> +genassym.o: opt_global.h
> +.endif
>  .if exists(@)
>  genassym.o: @/${MACHINE_ARCH}/${MACHINE_ARCH}/genassym.c
>  .endif
> @@ -439,6 +442,10 @@
>  lint: ${SRCS}
>  	${LINT} ${LINTKERNFLAGS} ${CFLAGS:M-[DILU]*} ${.ALLSRC:M*.c}
>  
> +.if defined(KERNBUILDDIR)
> +${OBJS}: opt_global.h
> +.endif
> +
>  .include <bsd.dep.mk>
>  
>  cleandepend: cleanilinks
> 
> 
> BTW, reading kmod.mk the submit above only works if .depend doesn't exist.  It 
> won't work if you have run 'make depend' because of this:
> 
> .if !exists(${.OBJDIR}/${DEPENDFILE})
> ${OBJS}: ${SRCS:M*.h}
> .endif


Cheers,
-- 
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer