From owner-cvs-src  Mon Mar  3 17:36:41 2003
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id BC73637B401; Mon,  3 Mar 2003 17:36:39 -0800 (PST)
Received: from mail.chesapeake.net (chesapeake.net [205.130.220.14])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 7E38843FA3; Mon,  3 Mar 2003 17:36:38 -0800 (PST)
	(envelope-from jroberson@chesapeake.net)
Received: from localhost (jroberson@localhost)
	by mail.chesapeake.net (8.11.6/8.11.6) with ESMTP id h241abX37621;
	Mon, 3 Mar 2003 20:36:37 -0500 (EST)
	(envelope-from jroberson@chesapeake.net)
Date: Mon, 3 Mar 2003 20:36:37 -0500 (EST)
From: Jeff Roberson <jroberson@chesapeake.net>
To: Alfred Perlstein <bright@mu.org>
Cc: src-committers@FreeBSD.org, <cvs-src@FreeBSD.org>,
	<cvs-all@FreeBSD.org>, <bde@FreeBSD.org>
Subject: Re: cvs commit: src/sys/kern vfs_default.c
In-Reply-To: <20030304005638.GH43089@elvis.mu.org>
Message-ID: <20030303203530.D72102-100000@mail.chesapeake.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-src@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-src.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-src>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-src>
X-Loop: FreeBSD.ORG

On Mon, 3 Mar 2003, Alfred Perlstein wrote:

> * Jeff Roberson <jroberson@chesapeake.net> [030303 16:39] wrote:
> > On Mon, 3 Mar 2003, Alfred Perlstein wrote:
> > > >   Log:
> > > >    - Correct the wchan in vop_stdfsync()
> > > >
> > > >   This is almost what bde asked for.  There is some desire to have per fs wchans
> > > >   still but that is difficult giving the current arrangement of the code.
> >
> > char wchanbuf[7] = "  sync";
> > wchanbuf[0] = vp->v_type[0];
> > wchanbuf[1] = vp->v_type[1];
>
> Although I provided that intial suggestion I'm actually opposed to
> non-const strings being passed into tsleep.  The reaon being, if
> someone gets a process wedged, it should be trivial to grep for the
> wchan that it's stuck in.  Adding something like this, while pretty
> actually would make it harder to debug things later.
>
> While this one exception wouldn't be too bad I'm afraid it will lead
> to (un)clever abuses later.
>

Any comments bde?  This seems like a bit of a judgement call to me.  I'm
not sure which I prefer.

Cheers,
Jeff


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-src" in the body of the message