From owner-freebsd-mips@FreeBSD.ORG Sat Jul 4 05:04:34 2009 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3E9D2106564A for ; Sat, 4 Jul 2009 05:04:34 +0000 (UTC) (envelope-from neelnatu@yahoo.com) Received: from web34404.mail.mud.yahoo.com (web34404.mail.mud.yahoo.com [66.163.178.153]) by mx1.freebsd.org (Postfix) with SMTP id F3B218FC17 for ; Sat, 4 Jul 2009 05:04:33 +0000 (UTC) (envelope-from neelnatu@yahoo.com) Received: (qmail 13049 invoked by uid 60001); 4 Jul 2009 05:04:33 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1246683873; bh=O3JQGv1gIygBtVW90wSrV/C7ofOChzofugx7ARKf/k0=; h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:MIME-Version:Content-Type; b=rtOcgH2ytUY85BHmybBUDa29hbb3XXeh12YWdPkwLdiBVAe3SS2uW8VkwtH016rIoXk08u39Gs2Gkz4oo4KvlBtO7W320UTQ4LTX6lZs6mjdNdQGcR5ntioawap71rF5a7h5gmEX7c4jATUtM7g98BnK7/mLw+yRuPRaUXOBNPE= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:MIME-Version:Content-Type; b=SaL7StWQFc6gnEDR2+P3ecHBHPQ9RMjJEUBX5r2MtqFrPsApo98JPzmRDgFduVQ9qY25ufuxz6jbq4dQX79vpuf5kvHNUkjCkZyfhvxnNYd+g149puN5jaOPm1FjUToeS0HWnf19kgQEOa0JUKPl+qUPL6o3HZsqSWhF1G06r7g=; Message-ID: <385015.11949.qm@web34404.mail.mud.yahoo.com> X-YMail-OSG: pdcJ6rAVM1ljAz_IO_rsKnJ.KrRoaL4Z7KXax8GdiFBUpsNjlk3cAXpr240awzp5QpJ27nKwd6FkJMWzNvLvc05alhvWUmH0OEJV8iZCcqCgjwuMiTRP5VtmDwWEHR_sugQ.yW0BeC6Rk3FVbSW4F3TkWixDxZ2hD0xufoI6WDJs__daV9wrUO0jPDTB3TiL227yDj6Yr1xqvCrrbOQq0OyOEkzv1w2I6kd81rj.FMoMOsfi_h23V18mvvuwF1U7OgNKC7TrlEIP0vSz4pIy7UYQmRYOFKczkJ5K0b.FKEggdMNBPmKyaKSna8VOZeDvmpUkcjMYqqvMXi.tUsKv_Fc9 Received: from [198.95.226.230] by web34404.mail.mud.yahoo.com via HTTP; Fri, 03 Jul 2009 22:04:33 PDT X-Mailer: YahooMailClassic/5.4.17 YahooMailWebService/0.7.289.15 Date: Fri, 3 Jul 2009 22:04:33 -0700 (PDT) From: Neelkanth Natu To: "M. Warner Losh" MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: freebsd-mips@freebsd.org Subject: Re: Machine Check exception during bootup X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Jul 2009 05:04:34 -0000 Hi Warner, --- On Fri, 7/3/09, M. Warner Losh wrote: > From: M. Warner Losh > Subject: Re: Machine Check exception during bootup > To: neelnatu@yahoo.com > Cc: freebsd-mips@freebsd.org > Date: Friday, July 3, 2009, 8:11 PM > In message: <122643.47019.qm@web34403.mail.mud.yahoo.com> > Neelkanth Natu > > writes: > : ==== > //depot/user/neelnatu/freebsd_sibyte/src/sys/mips/mips/genassym.c#1 > - /u/neelnatu/p4/freebsd_sibyte/src/sys/mips/mips/genassym.c > ==== > : @@ -91,6 +91,7 @@ > : ASSYM(SIGF_UC, offsetof(struct sigframe, sf_uc)); > : ASSYM(SIGFPE, SIGFPE); > : ASSYM(PGSHIFT, PGSHIFT); > : +ASSYM(PAGE_SHIFT, PAGE_SHIFT); > : ASSYM(NBPG, NBPG); > : ASSYM(SEGSHIFT, SEGSHIFT); > : ASSYM(NPTEPG, NPTEPG); > > How do PAGE_SHIFT and PGSHIFT differ? They are identical. I looked at other architectures and it seems that PGSHIFT is a macro defined for mips alone. The same is true for PGOFSET and PAGE_MASK. So I went with the obvious macro - PAGE_SHIFT. I think we should toast PGSHIFT and PGOFFSET and replace them with PAGE_SHIFT and PAGE_MASK respectively. What do you think? best Neel > > Warner >