Date: Mon, 4 Dec 2000 22:37:51 -0800 From: Michael Haro <mharo@FreeBSD.ORG> To: Akinori MUSHA <knu@iDaemons.org> Cc: Will Andrews <will@physics.purdue.edu>, Maxim Sobolev <sobomax@FreeBSD.ORG>, Michael Haro <mharo@FreeBSD.ORG>, FreeBSD-ports <freebsd-ports@FreeBSD.ORG> Subject: Re: portlint update Message-ID: <20001204223751.A59334@FreeBSD.org> In-Reply-To: <86sno3pffa.wl@archon.local.idaemons.org>; from knu@iDaemons.org on Tue, Dec 05, 2000 at 03:09:45PM %2B0900 References: <86u28kwghs.wl@archon.local.idaemons.org> <3A2B895D.D67E403A@FreeBSD.org> <86sno4w5g6.wl@archon.local.idaemons.org> <3A2BBF80.9CC69A1E@FreeBSD.org> <86r93ovxag.wl@archon.local.idaemons.org> <20001204224011.A570@puck.firepipe.net> <86sno3pffa.wl@archon.local.idaemons.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--mP3DRpeJDSE+ciuQ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, Dec 05, 2000 at 03:09:45PM +0900, Akinori MUSHA wrote:
>=20
> By the way, I found another bug...
>=20
> @@ -415,9 +306,10 @@
> =20
> open(IN, "< $file") || return 0;
> while (<IN>) {
> - $linecnt++;
> - $longlines++ if ($maxchars{$file} < length(chomp($_)));
> $tmp .=3D $_;
> + chomp || &perror("WARN: $file should terminate in '\n'.");
> + $linecnt++;
> + $longlines++ if ($maxchars{$file} < length);
> }
> if ($linecnt > $maxlines{$file}) {
> &perror("WARN: $file $errmsg{$file}".
>=20
> As `length(chomp($_))' is always either 0 or 1, the maxchars check
> hasn't been working at all. ;(
>=20
> I think I've committed many ports which pkg-comment's are over 70
> bytes in length... *shudder*
This check has already been fixed in portlint3.
Michael
--mP3DRpeJDSE+ciuQ
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: PGPfreeware 5.0i for non-commercial use
MessageID: bhuS2cAVVC/GGGqEFkxLFevZW/FBatIE
iQA/AwUBOiyNPuKkMfh7htP/EQIHIACgn4tJ3vl7Xdfhumm0S6IzItdMNh0AoMF6
lrs+S4FTVGr+5o3xirNvhFc9
=tUL4
-----END PGP SIGNATURE-----
--mP3DRpeJDSE+ciuQ--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001204223751.A59334>