From owner-freebsd-current@FreeBSD.ORG  Mon Oct 24 13:55:27 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C676D1065673;
	Mon, 24 Oct 2011 13:55:27 +0000 (UTC)
	(envelope-from luchesar.iliev@gmail.com)
Received: from mail-gx0-f182.google.com (mail-gx0-f182.google.com
	[209.85.161.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 63FC98FC14;
	Mon, 24 Oct 2011 13:55:27 +0000 (UTC)
Received: by ggnq2 with SMTP id q2so5843363ggn.13
	for <multiple recipients>; Mon, 24 Oct 2011 06:55:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=message-id:disposition-notification-to:date:from:user-agent
	:mime-version:to:cc:subject:references:in-reply-to
	:x-enigmail-version:openpgp:content-type:content-transfer-encoding;
	bh=NfctXVWUXFobFX4C6Xr0GGt4/uNvvP/W72ns0FXsR/s=;
	b=R9peyNpE56pS9H++1PXYaqk2WUtmRkKsifTbAIvJkJIYciMPGMbkSAuzbwtByaEF0d
	dSgJ1Ey2A/b00CylRqFDi+SyeQKxSLMSUbFZlbKA6u2dIjdmlhrLxaFK94O0XRjX/4G/
	YPuHTVzgm25SK8CzIP7KN5ZubYetFPoqXFc90=
Received: by 10.223.4.215 with SMTP id 23mr43706517fas.8.1319464526335;
	Mon, 24 Oct 2011 06:55:26 -0700 (PDT)
Received: from [79.124.93.41] ([79.124.93.41])
	by mx.google.com with ESMTPS id a1sm42735214fab.4.2011.10.24.06.55.24
	(version=SSLv3 cipher=OTHER); Mon, 24 Oct 2011 06:55:25 -0700 (PDT)
Message-ID: <4EA56E4B.9090802@gmail.com>
Date: Mon, 24 Oct 2011 16:55:23 +0300
From: "Luchesar V. ILIEV" <luchesar.iliev@gmail.com>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:7.0.1) Gecko/20111020 Thunderbird/7.0.1
MIME-Version: 1.0
To: John Baldwin <jhb@freebsd.org>
References: <20111020114844.GK59810@albert.catwhisker.org>
	<alpine.BSF.2.00.1110220801140.38610@toaster.local>
	<4EA2EFDD.4020507@gmail.com> <201110240759.54727.jhb@freebsd.org>
In-Reply-To: <201110240759.54727.jhb@freebsd.org>
X-Enigmail-Version: undefined
OpenPGP: id=9A1FEEFF;
	url=https://cert.acad.bg/pgp-keys/
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Garrett Cooper <yanegomi@gmail.com>,
	Craig Rodrigues <rodrigc@crodrigues.org>,
	freebsd-current@freebsd.org, Doug Barton <dougb@freebsd.org>
Subject: Re: sys/conf/newvers.sh vs. subversion-1.7
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Oct 2011 13:55:27 -0000

On 24/10/2011 14:59, John Baldwin wrote:
> On Saturday, October 22, 2011 12:31:25 pm Luchesar V. ILIEV wrote:
>> Speaking of that, and in the context of the recursion that svnversion
>> does, something else comes to my mind...
>>
>> svnversion is currently executed in ${SRCDIR}/sys, so the revision
>> number is relevant only to the kernel sources. But FreeBSD is not just a
>> kernel, unlike Linux, so wouldn't it make more sense to actually check
>> the revision directly at ${SRCDIR}, thus catching possible different
>> revisions in other parts of the base system source tree?
> 
> Please no.  That makes svnversion take a _lot_ longer.  We used to do that,
> but changed it.  Also, the kernel build does not use any sources outside
> of sys/, so for the kernel an svnversion of sys/ is perfectly reasonable.
> 

Sorry, it's my fault not noticing that it used to be that way. I also
guess that the topic has been discussed, so I'm sure all the pros and
cons have been well weighted. Thanks for the clarification.

Cheers,
Luchesar