From owner-cvs-all Mon Aug 13 23:36:17 2001 Delivered-To: cvs-all@freebsd.org Received: from bazooka.unixfreak.org (bazooka.unixfreak.org [63.198.170.138]) by hub.freebsd.org (Postfix) with ESMTP id 6036837B407; Mon, 13 Aug 2001 23:36:08 -0700 (PDT) (envelope-from dima@unixfreak.org) Received: by bazooka.unixfreak.org (Postfix, from userid 1000) id 92FF83E28; Mon, 13 Aug 2001 23:36:07 -0700 (PDT) Received: from bazooka.unixfreak.org (localhost [127.0.0.1]) by bazooka.unixfreak.org (Postfix) with ESMTP id 8762C3C12D; Mon, 13 Aug 2001 23:36:07 -0700 (PDT) To: Nik Clayton Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: doc/en_US.ISO8859-1/books/handbook/contrib chapter.sgml In-Reply-To: <20010812105850.N50182@canyon.nothing-going-on.org>; from nik@freebsd.org on "Sun, 12 Aug 2001 10:58:50 +0100" Date: Mon, 13 Aug 2001 23:36:02 -0700 From: Dima Dorfman Message-Id: <20010814063607.92FF83E28@bazooka.unixfreak.org> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Nik Clayton writes: > On Sat, Aug 11, 2001 at 01:15:56PM -0700, Dima Dorfman wrote: > > Modified files: > > en_US.ISO8859-1/books/handbook/contrib chapter.sgml=20 > > Log: > > Mention that [PATCH] in the synopsis of a PR could indicate that the > > PR includes a patch suitable for committing. I don't think this is > > the best place to put something like this, but it's better than > > nothing. > > How about in the definition of the SYNOPSIS_C variable in > src/gnu/usr.bin/send-pr/send-pr.sh ? There's too little room. Saying "use [PATCH] if there's a patch" isn't enough, because people will start sticking that on even if the patch they send doesn't come close to fixing the problem (and they know it). I've seen a few of these, and they're much worse than PRs with patches but without [PATCH]. If we start getting too many of the former, soon everyne will start ignoring [PATCH], and we'll need a new idiom. Repeat ad nauseam. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message