Date: Tue, 1 Oct 2002 09:04:56 +1000 From: Edwin Groothuis <edwin@mavetju.org> To: Ernst de Haan <znerd@FreeBSD.org> Cc: FreeBSD-gnats-submit@FreeBSD.org, mharo@FreeBSD.org Subject: Re: ports/43537: portlint 2.3.3 does not handle URLs that end in '.html' Message-ID: <20020930230456.GA934@k7.mavetju> In-Reply-To: <200209301835.g8UIZmUC000890@localhost.jollem.com> References: <200209301835.g8UIZmUC000890@localhost.jollem.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Sep 30, 2002 at 08:35:48PM +0200, Ernst de Haan wrote:
>
> >Number: 43537
> >Category: ports
> >Synopsis: portlint 2.3.3 does not handle URLs that end in '.html'
> >Confidential: no
> >Severity: non-critical
> >Priority: low
> >Responsible: freebsd-ports
> >State: open
> >Quarter:
> >Keywords:
> >Date-Required:
> >Class: change-request
> >Submitter-Id: current-users
> >Arrival-Date: Mon Sep 30 11:40:01 PDT 2002
> >Closed-Date:
> >Last-Modified:
> >Originator: Ernst de Haan
> >Release: FreeBSD 4.6-STABLE i386
> >Organization:
> FreeBSD Project
> >Environment:
> System: FreeBSD heinz 4.6-STABLE FreeBSD 4.6-STABLE #2: Wed Aug 28 23:38:45 CEST 2002 root@heinz:/usr/obj/usr/src/sys/HEINZ i386
> >Description:
> When I run portlint on ports/java/jdk12, I get
> >How-To-Repeat:
> # cd /usr/ports/java/jdk12
> # portlint
> OK: checking /usr/home/ernst/freebsd/ports/java/jdk12/pkg-comment.
> OK: checking /usr/home/ernst/freebsd/ports/java/jdk12/pkg-descr.
> OK: checking Makefile.
> WARN: Makefile 85: whitespace before end of line.
> WARN: possible direct use of command "awk" found. use ${AWK} instead.
> WARN: possible direct use of command "install" found. use ${INSTALL_foobaa} instead.
> WARN: possible use of absolute pathname "/usr/bin/cpio", in Makefile.
> FATAL: URL "http://www.sun.com/software/java2/download.html" should end with "/".
> WARN: extra item placed in the *_DEPENDS section.
> WARN: "PKGNAMESUFFIX" has to appear earlier in Makefile.
> OK: checking /usr/home/ernst/freebsd/ports/java/jdk12/distinfo.
> OK: checking /usr/home/ernst/freebsd/ports/java/jdk12/files/patch-aa.
> 1 fatal errors and 6 warnings found.
>
> The 'FATAL' line is incorrect IMO.
I don't agree with you that the URL on the FATAL line is incorrect(*),
but I do disagree with you that the message is incorrect.
Please check the Makefile, it has as MASTER_SITES:
MASTER_SITES= # http://www.sun.com/software/java2/download.html
# http://www.eyesbeyond.com/freebsddom/java/jdk.html
Actually, this is "MASTER_SITES= " (verified with make -V MASTER_SITES).
Portlint doesn't pick this up because it thinks that the string "#
http://www.sun.com/software/java2/download.html" is the value for
MASTER_SITES.
So portlint should be taught[sp, past tense of to teach] that it
should ignore everything after the #. But not for everything, only
for lines which don't have # at the first character:
--- /tmp/portlint Tue Oct 1 08:31:35 2002
+++ portlint Tue Oct 1 08:44:22 2002
@@ -706,6 +706,7 @@
# next;
# }
# next if ($tmp);
+ s/^(.+)#.*?([\t ]*)$/$1$2/;
$rawwhole .= $_;
}
close(IN);
With this patch, portlint gives me not the FATAL about the URL.
(*) It is incorrect for the ports-system because the ports system
will just append ${PORTNAME}-${PORTVERSION} to it, making it
http://www/blaat.htmljdk-1.2.tar.gz which 404s as well. Maybe
support for http://www/blaat?jdk-1.2.tar.gz should be added?
Edwin
--
Edwin Groothuis | Personal website: http://www.MavEtJu.org
edwin@mavetju.org | Weblog: http://www.mavetju.org/weblog/weblog.php
bash$ :(){ :|:&};: | Interested in MUDs? http://www.FatalDimensions.org/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020930230456.GA934>