From owner-cvs-src@FreeBSD.ORG  Fri Jan 12 15:59:11 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@freebsd.org
Delivered-To: cvs-src@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 8F8E716A501
	for <cvs-src@freebsd.org>; Fri, 12 Jan 2007 15:59:11 +0000 (UTC)
	(envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 4D1B213C44B
	for <cvs-src@freebsd.org>; Fri, 12 Jan 2007 15:59:11 +0000 (UTC)
	(envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id l0CFv0M3090808;
	Fri, 12 Jan 2007 08:57:01 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Fri, 12 Jan 2007 08:57:15 -0700 (MST)
Message-Id: <20070112.085715.1541726517.imp@bsdimp.com>
To: dmitry@atlantis.dp.ua
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20070112140211.G555@atlantis.atlantis.dp.ua>
References: <200701120740.l0C7eULD026513@repoman.freebsd.org>
	<20070112140211.G555@atlantis.atlantis.dp.ua>
X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0
	(harmony.bsdimp.com [127.0.0.1]);
	Fri, 12 Jan 2007 08:57:01 -0700 (MST)
Cc: cvs-src@freebsd.org
Subject: Re: cvs commit: src/sys/kern kern_ntptime.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Jan 2007 15:59:11 -0000

In message: <20070112140211.G555@atlantis.atlantis.dp.ua>
            Dmitry Pryanishnikov <dmitry@atlantis.dp.ua> writes:
: 
: Hello!
: 
: On Fri, 12 Jan 2007, Warner Losh wrote:
: >    sys/kern             kern_ntptime.c
: >  Log:
: >  When ntp_gettime() was converted from a sysctl + wrapper to a system
: >  call, its semantics were unintentionally changed.  It went from
: >  returning the time state to returning 0 or -1.  Since 0 means time
: 
:    Shouldn't the manpage lib/libc/sys/ntp_gettime.2 also be updated? It claims
: now:
: 
: RETURN VALUES
:       The ntp_gettime() function returns the value 0 if successful; otherwise
:       the value -1 is returned and the global variable errno is set to indicate
:       the error.
: 
:       Possible states of the clock are:
:  	...
: 
: So it still refers to old behaviour (return either 0 or -1), which is 
: confusing enough.

Yes.  This needs to be fixed.

Warner