From owner-p4-projects@FreeBSD.ORG Sat Jan 21 12:11:13 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id AD88516A422; Sat, 21 Jan 2006 12:11:12 +0000 (GMT) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 52F9816A420 for ; Sat, 21 Jan 2006 12:11:12 +0000 (GMT) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0285843D4C for ; Sat, 21 Jan 2006 12:11:12 +0000 (GMT) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k0LCBBHs069945 for ; Sat, 21 Jan 2006 12:11:11 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k0LCBBZc069942 for perforce@freebsd.org; Sat, 21 Jan 2006 12:11:11 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Date: Sat, 21 Jan 2006 12:11:11 GMT Message-Id: <200601211211.k0LCBBZc069942@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f From: Robert Watson To: Perforce Change Reviews Cc: Subject: PERFORCE change 90060 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jan 2006 12:11:13 -0000 http://perforce.freebsd.org/chv.cgi?CH=90060 Change 90060 by rwatson@rwatson_sesame on 2006/01/21 12:10:52 Don't take a pointer to an array. Don't return (void) -- gcc is fine with it, but is C? Affected files ... .. //depot/projects/trustedbsd/openbsm/libbsm/bsm_io.c#20 edit Differences ... ==== //depot/projects/trustedbsd/openbsm/libbsm/bsm_io.c#20 (text+ko) ==== @@ -551,7 +551,7 @@ break; case AU_IPv6: - READ_TOKEN_BYTES(buf, len, &tok->tt.hdr32_ex.addr, + READ_TOKEN_BYTES(buf, len, tok->tt.hdr32_ex.addr, sizeof(tok->tt.hdr32_ex.addr), tok->len, err); break; } @@ -2533,115 +2533,115 @@ switch(tok->id) { case AUT_HEADER32: - return (print_header32_tok(outfp, tok, del, raw, sfrm)); + print_header32_tok(outfp, tok, del, raw, sfrm); case AUT_HEADER32_EX: - return (print_header32_ex_tok(outfp, tok, del, raw, sfrm)); + print_header32_ex_tok(outfp, tok, del, raw, sfrm); case AUT_HEADER64: - return (print_header64_tok(outfp, tok, del, raw, sfrm)); + print_header64_tok(outfp, tok, del, raw, sfrm); case AUT_HEADER64_EX: - return (print_header64_ex_tok(outfp, tok, del, raw, sfrm)); + print_header64_ex_tok(outfp, tok, del, raw, sfrm); case AUT_TRAILER: - return (print_trailer_tok(outfp, tok, del, raw, sfrm)); + print_trailer_tok(outfp, tok, del, raw, sfrm); case AUT_ARG32: - return (print_arg32_tok(outfp, tok, del, raw, sfrm)); + print_arg32_tok(outfp, tok, del, raw, sfrm); case AUT_ARG64: - return (print_arg64_tok(outfp, tok, del, raw, sfrm)); + print_arg64_tok(outfp, tok, del, raw, sfrm); case AUT_DATA: - return (print_arb_tok(outfp, tok, del, raw, sfrm)); + print_arb_tok(outfp, tok, del, raw, sfrm); case AUT_ATTR32: - return (print_attr32_tok(outfp, tok, del, raw, sfrm)); + print_attr32_tok(outfp, tok, del, raw, sfrm); case AUT_ATTR64: - return (print_attr64_tok(outfp, tok, del, raw, sfrm)); + print_attr64_tok(outfp, tok, del, raw, sfrm); case AUT_EXIT: - return (print_exit_tok(outfp, tok, del, raw, sfrm)); + print_exit_tok(outfp, tok, del, raw, sfrm); case AUT_EXEC_ARGS: - return (print_execarg_tok(outfp, tok, del, raw, sfrm)); + print_execarg_tok(outfp, tok, del, raw, sfrm); case AUT_EXEC_ENV: - return (print_execenv_tok(outfp, tok, del, raw, sfrm)); + print_execenv_tok(outfp, tok, del, raw, sfrm); case AUT_OTHER_FILE32: - return (print_file_tok(outfp, tok, del, raw, sfrm)); + print_file_tok(outfp, tok, del, raw, sfrm); case AUT_NEWGROUPS: - return (print_newgroups_tok(outfp, tok, del, raw, sfrm)); + print_newgroups_tok(outfp, tok, del, raw, sfrm); case AUT_IN_ADDR: - return (print_inaddr_tok(outfp, tok, del, raw, sfrm)); + print_inaddr_tok(outfp, tok, del, raw, sfrm); case AUT_IN_ADDR_EX: - return (print_inaddr_ex_tok(outfp, tok, del, raw, sfrm)); + print_inaddr_ex_tok(outfp, tok, del, raw, sfrm); case AUT_IP: - return (print_ip_tok(outfp, tok, del, raw, sfrm)); + print_ip_tok(outfp, tok, del, raw, sfrm); case AUT_IPC: - return (print_ipc_tok(outfp, tok, del, raw, sfrm)); + print_ipc_tok(outfp, tok, del, raw, sfrm); case AUT_IPC_PERM: - return (print_ipcperm_tok(outfp, tok, del, raw, sfrm)); + print_ipcperm_tok(outfp, tok, del, raw, sfrm); case AUT_IPORT: - return (print_iport_tok(outfp, tok, del, raw, sfrm)); + print_iport_tok(outfp, tok, del, raw, sfrm); case AUT_OPAQUE: - return (print_opaque_tok(outfp, tok, del, raw, sfrm)); + print_opaque_tok(outfp, tok, del, raw, sfrm); case AUT_PATH: - return (print_path_tok(outfp, tok, del, raw, sfrm)); + print_path_tok(outfp, tok, del, raw, sfrm); case AUT_PROCESS32: - return (print_process32_tok(outfp, tok, del, raw, sfrm)); + print_process32_tok(outfp, tok, del, raw, sfrm); case AUT_PROCESS32_EX: - return (print_process32ex_tok(outfp, tok, del, raw, sfrm)); + print_process32ex_tok(outfp, tok, del, raw, sfrm); case AUT_RETURN32: - return (print_return32_tok(outfp, tok, del, raw, sfrm)); + print_return32_tok(outfp, tok, del, raw, sfrm); case AUT_RETURN64: - return (print_return64_tok(outfp, tok, del, raw, sfrm)); + print_return64_tok(outfp, tok, del, raw, sfrm); case AUT_SEQ: - return (print_seq_tok(outfp, tok, del, raw, sfrm)); + print_seq_tok(outfp, tok, del, raw, sfrm); case AUT_SOCKET: - return (print_socket_tok(outfp, tok, del, raw, sfrm)); + print_socket_tok(outfp, tok, del, raw, sfrm); case AUT_SOCKINET32: - return (print_sock_inet32_tok(outfp, tok, del, raw, sfrm)); + print_sock_inet32_tok(outfp, tok, del, raw, sfrm); case AUT_SOCKUNIX: - return (print_sock_unix_tok(outfp, tok, del, raw, sfrm)); + print_sock_unix_tok(outfp, tok, del, raw, sfrm); case AUT_SUBJECT32: - return (print_subject32_tok(outfp, tok, del, raw, sfrm)); + print_subject32_tok(outfp, tok, del, raw, sfrm); case AUT_SUBJECT64: - return (print_subject64_tok(outfp, tok, del, raw, sfrm)); + print_subject64_tok(outfp, tok, del, raw, sfrm); case AUT_SUBJECT32_EX: - return (print_subject32ex_tok(outfp, tok, del, raw, sfrm)); + print_subject32ex_tok(outfp, tok, del, raw, sfrm); case AUT_TEXT: - return (print_text_tok(outfp, tok, del, raw, sfrm)); + print_text_tok(outfp, tok, del, raw, sfrm); case AUT_SOCKET_EX: - return (print_socketex32_tok(outfp, tok, del, raw, sfrm)); + print_socketex32_tok(outfp, tok, del, raw, sfrm); default: - return (print_invalid_tok(outfp, tok, del, raw, sfrm)); + print_invalid_tok(outfp, tok, del, raw, sfrm); } }