From owner-freebsd-gnome@FreeBSD.ORG Wed Jun 9 02:00:31 2004 Return-Path: Delivered-To: freebsd-gnome@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7989216A4CE; Wed, 9 Jun 2004 02:00:31 +0000 (GMT) Received: from lakermmtao04.cox.net (lakermmtao04.cox.net [68.230.240.35]) by mx1.FreeBSD.org (Postfix) with ESMTP id E6F0443D48; Wed, 9 Jun 2004 02:00:28 +0000 (GMT) (envelope-from mezz7@cox.net) Received: from mezz ([68.103.32.140]) by lakermmtao04.cox.net (InterMail vM.6.01.03.02 201-2131-111-104-20040324) with ESMTP id <20040609020026.YODB12116.lakermmtao04.cox.net@mezz>; Tue, 8 Jun 2004 22:00:26 -0400 Date: Tue, 08 Jun 2004 21:01:02 -0500 To: "Adam Weinberger" References: <20040608175318.GY72578@toxic.magnesium.net> <20040608185934.GB72578@toxic.magnesium.net> <20040609003811.GC72578@toxic.magnesium.net> From: "Jeremy Messenger" Content-Type: text/plain; format=flowed; delsp=yes; charset=iso-8859-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID: In-Reply-To: <20040609003811.GC72578@toxic.magnesium.net> User-Agent: Opera M2/7.51 (Linux, build 689) cc: freebsd-gnome@freebsd.org Subject: Re: Need feedback/review, a big change in AbiWord2 port. X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2004 02:00:31 -0000 On Tue, 8 Jun 2004 20:38:11 -0400, Adam Weinberger wrote: >>> (06.08.2004 @ 1513 PST): Jeremy Messenger said, in 3.8K: << >> >>>> - Change the default spell from Enchant to Aspell, because it >> doesn't >> >>>> work at all unless you compile Enchant with the Aspell support. I >> >>>> think, it's waste to depend on Enchant by default. >> >>>> >> >>>> Also, I have removed the check of Enchant. I prefer to see force >> >>>> user to want use Enchant if they know what to do with it. I need >> >>>> the >> >>>> help on write the better comment in @${ECHO_CMD} about this. >> >>> >> >>>I disagree strongly with this. I think that Enchant is a great idea. >> >>>Enchant isn't being utilized properly ATM, but it has the propensity >> to >> >>>be a great leap forward in i18n spell-checking. >> >> >> >>What's your best suggest then? Force Enchant to compile with Aspell >> >>support? This is the way that I will allow Enchant to be default. It >> >>doesn't make any sense to have something that will not work by >> default. >> >>I >> >>think, it's important to have the default that is just work. >> > >> >Enchant should theoretically work fine without aspell support. But, I >> >think that Enchant should be enabled by defaultm, and should work >> >out-of-the-box, by whatever means necessary. >> >> Do you mean, you think we should change Enchant port to compile with >> Aspell support? If no, then I will not switch Aspell to Enchant for the >> default spell, unless you have anything to fix it. >>> end of "Re: Need feedback/review, a big change in AbiWord2 port." from >>> Jeremy Messenger << > > Yes. If Enchant needs aspell support for AbiWord2 to work best, then > Enchant should depend upon aspell by default. With those diffs, now the spell works by default with Enchant. No object tonight and I will commit those by tomorrow. Thanks for review/feedback, marcus and adamw! http://people.freebsd.org/~mezz/diff/enchant.diff http://people.freebsd.org/~mezz/diff/AbiWord2.diff Cheers, Mezz > # Adam > > > -- > Adam Weinberger > adamw@magnesium.net || adamw@FreeBSD.org > adamw@vectors.cx || adamw@gnome.org > http://www.vectors.cx -- mezz7@cox.net - mezz@FreeBSD.org FreeBSD GNOME Team http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org