From owner-freebsd-stable Thu Apr 13 16:19:35 2000 Delivered-To: freebsd-stable@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (Postfix) with ESMTP id F0AA537B538; Thu, 13 Apr 2000 16:19:32 -0700 (PDT) (envelope-from kris@FreeBSD.org) Received: from localhost (kris@localhost) by freefall.freebsd.org (8.9.3/8.9.2) with ESMTP id QAA48154; Thu, 13 Apr 2000 16:19:32 -0700 (PDT) (envelope-from kris@FreeBSD.org) X-Authentication-Warning: freefall.freebsd.org: kris owned process doing -bs Date: Thu, 13 Apr 2000 16:19:32 -0700 (PDT) From: Kris Kennaway To: Warner Losh Cc: "Jordan K. Hubbard" , Robin Melville , Doug Barton , stable@FreeBSD.org Subject: Re: 4.0, OpenSSL and MD5 (fwd) In-Reply-To: <200004132314.RAA48943@harmony.village.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Thu, 13 Apr 2000, Warner Losh wrote: > NO_FOO?=no > > .if ${NO_FOO} != "no" > do foo > .endif > > works quite well. Where to put the NO_FOO?= line is harder to know, > but certainly it is a solvable problem. Maybe in a bsd.default.mk > file, which is included early in the bsd.* files. The problem comes when you have things like: .if exists(${.CURDIR}/../../secure) && !defined(NOCRYPT) && !defined(NOSECURE) && !defined(NO_OPENSSL) && !defined(RELEASE_CRUNCH) where it becomes an unreadable mess to test each of the options for their values as well. I've simplified this kind of statement a lot by making variables automatically imply their subsidiaries in Makefile.inc1, but the more complicated the expression is the greater the chance of misreading it (a lot of the ones we have now have missing/wrong clauses). Kris ---- In God we Trust -- all others must submit an X.509 certificate. -- Charles Forsythe To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message