From nobody Sat Apr 25 13:58:49 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g2rzD4066z6bXYc for ; Sat, 25 Apr 2026 13:59:04 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g2rzC6Dk7z4QFr for ; Sat, 25 Apr 2026 13:59:03 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-488ab2db91aso121135235e9.3 for ; Sat, 25 Apr 2026 06:59:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777125542; x=1777730342; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=0g7RXkYXySmY5puVh+zEj7lklqmSZEZW2k6CkGmZjBQ=; b=I5tr9wUC5HHKopsgp5Vf+dg1vgR/1wjf/ehdm28zZhAUQ5IZst5QOPJ7ZSLt/XAvvG +An7NyOYh27hmt+51uUMktW6RSUaBZ1rh5DAF/Hl9e3s2BDX/1OecFr+lo3x79qt2Yw9 tTjb/arghYXKz9Ruy9kRC+pCriscJ3+tfCHywnZUoEyBpIxQ77gQx5WB2la0MPcOG2VY 1RzFk7pMynmaA9KyrmEnp6wwQJd1KPEiVSIrfMMr9hFH1QkjZtSDbToZnBVmYDg/wDJR 5LQ/xEKK9MH1+ufBy1jiCmmmbekazbaYgs+yvE65LGqJcZtmXWU75bqTghvD0Ep+urYP pGaA== X-Forwarded-Encrypted: i=1; AFNElJ/eKceOYH75pNXDHk0nCgDn8FhXqnDXL7pa+Gw3LrLeeozXp6qMg4B/mC7+Ria4yEP6RQyfh1V6AwX/bWTeukC+bhvp@freebsd.org X-Gm-Message-State: AOJu0YyXzo6c1nBVyaZQ6ccZYCFRPsfxCv18mZ0Y5D3oMExKxHfvasLw zaZJC8+jixwJOZ+aS4l6Rllibkh+UuJ+aNloyFLuxnxeKwGH06My/lGbumw3W4y3EL+v0DaDEu4 mWoA8V0M= X-Gm-Gg: AeBDietPYkF2lopFifVwdoLYefh0S53hzjNAqzHfPJGMFKAp+JrJdl96LaNBqYxy+v5 ncnCnkJvAqLL9W9FDzWXl7563nl3kvJZhy1NdYFb3nG5csi+IX9+DOTHA3Ei63v+fEjJGibLd42 n8yC2TqocS6UtCzVZHd/JWvmI7ylbIREHcWZM3i/gE3kJj3Z3Q21GQsblK5WaE8hcy8ppYchSLf vSx+oClWWMKW2l7AI/1Q86wh9sLONYnDQydgSVgD5cg68/Ivxi90MuDzYTmkycBqglOZyRkZppV 5q+0/rSOY7IBZlugVnjJbKjaYsiCs1oIPPM03dKLHtmOy6rrItu6/U0Szs+SWJs/D+ffpSCI/zH TfZibpMBH8oBEDwoUJUaCtKzaqln0H77bvLfmGBrYHM5GoaL7a4H6nqhjIKRwz1aCdmgsX8zk+Q BuJjMjpn8odioTFSedyE1RXow9/fxWdInYtzVz0FlesRG+Ti5b8EELGlIGd1LmwNBEiInOvnD+5 pkdaw== X-Received: by 2002:a05:600c:3412:b0:489:284:44ab with SMTP id 5b1f17b1804b1-489028446fbmr249955145e9.12.1777125541952; Sat, 25 Apr 2026 06:59:01 -0700 (PDT) Received: from smtpclient.apple (nat-184-78.net.cam.ac.uk. [131.111.184.78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a5a579bd3sm306518305e9.6.2026.04.25.06.59.00 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 25 Apr 2026 06:59:00 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\)) Subject: Re: git: 753a166bdeb3 - main - imgact_elf: Fix uninitialized variable use in note_procstat_auxv From: Jessica Clarke In-Reply-To: <673E90BE-4519-46D9-BF02-458830DCC304@FreeBSD.org> Date: Sat, 25 Apr 2026 14:58:49 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , Alex Richardson Content-Transfer-Encoding: quoted-printable Message-Id: <6BCE247D-8992-4603-8CFF-F7C87E464829@freebsd.org> References: <69ecc4df.33991.53b0871@gitrepo.freebsd.org> <7DD33B7A-A4B7-4AF7-9EA6-CF65BF388500@freebsd.org> <673E90BE-4519-46D9-BF02-458830DCC304@FreeBSD.org> To: Dimitry Andric X-Mailer: Apple Mail (2.3864.400.21) X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4g2rzC6Dk7z4QFr X-Spamd-Bar: ---- On 25 Apr 2026, at 14:53, Dimitry Andric wrote >=20 > On 25 Apr 2026, at 15:46, Jessica Clarke wrote: >>=20 >> On 25 Apr 2026, at 14:42, Dimitry Andric wrote: >>=20 >>> The branch main has been updated by dim: >>>=20 >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D753a166bdeb3aeba02fd9678e7360f09= 29007368 >>>=20 >>> commit 753a166bdeb3aeba02fd9678e7360f0929007368 >>> Author: Alex Richardson >>> AuthorDate: 2025-09-15 06:27:12 +0000 >>> Commit: Dimitry Andric >>> CommitDate: 2026-04-25 13:42:16 +0000 >>>=20 >>> imgact_elf: Fix uninitialized variable use in note_procstat_auxv >>>=20 >>> Found building with latest clang >>>=20 >>> MFC after: 3 days >>> --- >>> sys/kern/imgact_elf.c | 9 ++++++--- >>> 1 file changed, 6 insertions(+), 3 deletions(-) >>>=20 >>> diff --git a/sys/kern/imgact_elf.c b/sys/kern/imgact_elf.c >>> index af0841c75549..3c5fbe4df342 100644 >>> --- a/sys/kern/imgact_elf.c >>> +++ b/sys/kern/imgact_elf.c >>> @@ -2712,13 +2712,16 @@ __elfN(note_procstat_auxv)(void *arg, struct = sbuf *sb, size_t *sizep) >>> struct proc *p; >>> size_t size; >>> int structsize; >>> - >>> +#if defined(COMPAT_FREEBSD32) && __ELF_WORD_SIZE =3D=3D 32 >>> + structsize =3D sizeof(Elf32_Auxinfo); >>=20 >> Elf_Auxinfo *is* Elf32_Auxinfo for __ELF_WORD_SIZE =3D=3D 32? >>=20 >>> +#else >>> + structsize =3D sizeof(Elf_Auxinfo); >>> +#endif >>> p =3D arg; >>> structsize =3D sizeof(Elf_Auxinfo); >>=20 >> But it=E2=80=99s initialised right here? So that assignment is dead? >>=20 >>> if (sb =3D=3D NULL) { >>> size =3D 0; >>> - sb =3D sbuf_new(NULL, NULL, AT_COUNT * sizeof(Elf_Auxinfo), >>> - SBUF_FIXEDLEN); >>> + sb =3D sbuf_new(NULL, NULL, AT_COUNT * structsize, SBUF_FIXEDLEN); >>=20 >> These are equivalent? Though this one at least I see an argument for. >>=20 >>> sbuf_set_drain(sb, sbuf_count_drain, &size); >>> sbuf_bcat(sb, &structsize, sizeof(structsize)); >>> PHOLD(p); >>>=20 >>=20 >> I really don=E2=80=99t understand this change at all. I think all but = the final >> part should be reverted >=20 > I've only committed this because it's part of the llvm-21-update tree, = and on behalf of Alex. I think this was to suppress a bunch of warnings, = and I'm happing to fix it post-import, if there are no further errors. I mean, maybe once upon a time some early form of this patch was needed, but I have no clue what warning this could possibly have been fixing, it=E2=80=99s so clearly not right when you look at the diff. So = can we please revert this now rather than maybe at some point in the future? There=E2=80=99s no world in which this is sensible code to have in the = tree, and if you don=E2=80=99t revert it, I will. If anything I would expect = this to introduce *new* warnings due to the dead assignment to structsize that=E2=80=99s been added. Jessica