From owner-freebsd-current@FreeBSD.ORG Tue Oct 2 04:57:25 2007 Return-Path: Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 65DB716A46E; Tue, 2 Oct 2007 04:57:25 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id F13B713C467; Tue, 2 Oct 2007 04:57:23 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id l924vEaR001140; Mon, 1 Oct 2007 22:57:15 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <4701CFA2.4040700@samsco.org> Date: Mon, 01 Oct 2007 22:57:06 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 MIME-Version: 1.0 To: Scott Long , freebsd-scsi@FreeBSD.ORG, freebsd-current@FreeBSD.ORG, njl@FreeBSD.ORG References: <46E615C4.1010605@samsco.org> <20070916115427.GA1427@roadrunner.spoerlein.net> <46ED6C50.4040104@samsco.org> <20070918202250.GA1403@roadrunner.spoerlein.net> In-Reply-To: <20070918202250.GA1403@roadrunner.spoerlein.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Mon, 01 Oct 2007 22:57:15 -0600 (MDT) X-Spam-Status: No, score=-1.4 required=5.5 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: Subject: Re: Retirement of CAM_QUIRK_NOSERIAL X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 04:57:25 -0000 Ulrich Spoerlein wrote: > On Sun, 16.09.2007 at 11:48:00 -0600, Scott Long wrote: >> Ulrich Spoerlein wrote: >>> On Mon, 10.09.2007 at 22:12:52 -0600, Scott Long wrote: >>>> All, >>>> >>>> The attached patch should make CAM behave properly with regard to >>>> probing device serial numbers only when the device advertises that >>>> it supports it. It will hopefully eliminate the need for the >>>> CAM_QUIRK_NOSERIAL quirk (one instance is left because of an unrelated >>>> legacy problem that may or may not be possible to fix). This should >>>> especially benefit USB-UMASS devices, where the console output should >>>> be less noisy. It might even make more devices work out-of-the-box. >>> While this patch is working fine with my USB/FW HDD enclosure, it breaks >>> my MP3 USB stick >>> kernel: umass0: on uhub5 >>> kernel: umass0: BBB reset failed, IOERROR >>> kernel: umass0: BBB bulk-in clear stall failed, IOERROR >>> kernel: umass0: BBB bulk-out clear stall failed, IOERROR >> Is this a regression of something that works without the patch, or is >> it something that has never worked? What happens if you use the >> NO_INQUIRY_EVPD quirk instead? > > Ok, I played around a bit and with your patch applied, I have to > *remove* the quirk for my Samsung device, then it starts attaching > again. That's a good thing, right? :) > > umass0: on uhub3 > da0 at umass-sim0 bus 0 target 0 lun 0 > da0: Removable Direct Access SCSI-4 device > da0: 40.000MB/s transfers > da0: 999MB (511616 2048 byte sectors: 64H 32S/T 249C) > > There are only two other devices right now, that require a SHUTTLE_INIT > quirk, perhaps they are broken by your patch, too. > > Btw, why are there devices in umass.c with NO_QUIRKS set? Shouldn't > those entries be removed? > > Cheers, > Ulrich Spoerlein So where does this stand? Is my patch still a regression for you? Scott