Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 2 Mar 2019 08:01:30 -0500
From:      Dmitri Goutnik <dg@syrec.org>
To:        Ryan Steinmetz <zi@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r494348 - in head/textproc: . gron
Message-ID:  <20190302130129.GA78117@xombo.localdomain>
In-Reply-To: <201903020030.x220UiTg068294@repo.freebsd.org>
References:  <201903020030.x220UiTg068294@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 19-03-02 00:30:44, Ryan Steinmetz wrote:
> Author: zi
> Date: Sat Mar  2 00:30:44 2019
> New Revision: 494348
> URL: https://svnweb.freebsd.org/changeset/ports/494348
> 
> Log:
>   New port: textproc/gron:
>   
>   Make JSON greppable!
>   
>   gron transforms JSON into discrete assignments to make it easier to grep for
>   what you want and see the absolute 'path' to it. It eases the exploration of
>   APIs that return large blobs of JSON but have terrible documentation.
>   
>   WWW: https://github.com/tomnomnom/gron
> 
> Added:
>   head/textproc/gron/
>   head/textproc/gron/Makefile   (contents, props changed)
>   head/textproc/gron/distinfo   (contents, props changed)
>   head/textproc/gron/pkg-descr   (contents, props changed)
> Modified:
>   head/textproc/Makefile
> 
> Modified: head/textproc/Makefile
> ==============================================================================
> --- head/textproc/Makefile	Sat Mar  2 00:20:37 2019	(r494347)
> +++ head/textproc/Makefile	Sat Mar  2 00:30:44 2019	(r494348)
> @@ -234,6 +234,7 @@
>      SUBDIR += grc-aspell
>      SUBDIR += greple
>      SUBDIR += groff
> +    SUBDIR += gron
>      SUBDIR += groonga
>      SUBDIR += gsed
>      SUBDIR += gspell
> 
> Added: head/textproc/gron/Makefile
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/textproc/gron/Makefile	Sat Mar  2 00:30:44 2019	(r494348)
> @@ -0,0 +1,36 @@
> +# Created by: Ryan Steinmetz <zi@FreeBSD.org>
> +# $FreeBSD$
> +
> +PORTNAME=	gron
> +PORTVERSION=	0.6.0
> +DISTVERSIONPREFIX=	v
> +CATEGORIES=	textproc
> +
> +MAINTAINER=	zi@FreeBSD.org
> +COMMENT=	Transforms JSON into discrete assignments that are easier to grep
> +
> +LICENSE=	MIT
> +
> +USES=		go
> +USE_GITHUB=	yes
> +GH_ACCOUNT=	tomnomnom
> +GH_TUPLE=	fatih:color:v1.7.0:color \
> +		mattn:go-colorable:v0.1.1:colorable \
> +		mattn:go-isatty:v0.0.6:isatty \
> +		nwidger:jsoncolor:75a6de4:jsoncolor \
> +		pkg:errors:v0.8.1:pkg_errors
> +
> +PLIST_FILES=	bin/${PORTNAME}
> +
> +pre-build:
> +	${MKDIR} ${GO_WRKDIR_SRC}/github.com/fatih \
> +		${GO_WRKDIR_SRC}/github.com/mattn \
> +		${GO_WRKDIR_SRC}/github.com/pkg \
> +		${GO_WRKDIR_SRC}/github.com/nwidger
> +	${MV} ${WRKSRC_color} ${GO_WRKDIR_SRC}/github.com/fatih/color
> +	${MV} ${WRKSRC_colorable} ${GO_WRKDIR_SRC}/github.com/mattn/go-colorable
> +	${MV} ${WRKSRC_isatty} ${GO_WRKDIR_SRC}/github.com/mattn/go-isatty
> +	${MV} ${WRKSRC_jsoncolor} ${GO_WRKDIR_SRC}/github.com/nwidger/jsoncolor
> +	${MV} ${WRKSRC_pkg_errors} ${GO_WRKDIR_SRC}/github.com/pkg/errors

Using pre-build to setup deps seems a bit excessive:

-GH_TUPLE=      fatih:color:v1.7.0:color \
-               mattn:go-colorable:v0.1.1:colorable \
-               mattn:go-isatty:v0.0.6:isatty \
-               nwidger:jsoncolor:75a6de4:jsoncolor \
-               pkg:errors:v0.8.1:pkg_errors
+GH_TUPLE=      fatih:color:v1.7.0:color/vendor/github.com/fatih/color \
+               mattn:go-colorable:v0.1.1:colorable/vendor/github.com/mattn/go-colorable \
+               mattn:go-isatty:v0.0.6:isatty/vendor/github.com/mattn/go-isatty \
+               nwidger:jsoncolor:75a6de4:jsoncolor/vendor/github.com/nwidger/jsoncolor \
+               pkg:errors:v0.8.1:pkg_errors/vendor/github.com/pkg/errors

 PLIST_FILES=   bin/${PORTNAME}

-pre-build:
-       ${MKDIR} ${GO_WRKDIR_SRC}/github.com/fatih \
-               ${GO_WRKDIR_SRC}/github.com/mattn \
-               ${GO_WRKDIR_SRC}/github.com/pkg \
-               ${GO_WRKDIR_SRC}/github.com/nwidger
-       ${MV} ${WRKSRC_color} ${GO_WRKDIR_SRC}/github.com/fatih/color
-       ${MV} ${WRKSRC_colorable} ${GO_WRKDIR_SRC}/github.com/mattn/go-colorable
-       ${MV} ${WRKSRC_isatty} ${GO_WRKDIR_SRC}/github.com/mattn/go-isatty
-       ${MV} ${WRKSRC_jsoncolor} ${GO_WRKDIR_SRC}/github.com/nwidger/jsoncolor
-       ${MV} ${WRKSRC_pkg_errors} ${GO_WRKDIR_SRC}/github.com/pkg/errors

Upstream also recommends setting gronVersion [1], otherwise gron --version 
just reports "dev":

+GO_BUILDFLAGS= -ldflags="-X main.gronVersion=${PORTVERSION}"


[1] https://github.com/tomnomnom/gron/blob/master/main.go#L46

Regards,
Dmitri



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190302130129.GA78117>