From nobody Tue Feb 4 17:11:21 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YnVWV0pyPz5n7Q4; Tue, 04 Feb 2025 17:20:54 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta003.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YnVWT12ktz3W8m; Tue, 04 Feb 2025 17:20:53 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4004a.ext.cloudfilter.net ([10.228.9.227]) by cmsmtp with ESMTPS id fLxvtbNNRxv7PfMbUtfqHB; Tue, 04 Feb 2025 17:20:52 +0000 Received: from spqr.komquats.com ([70.66.136.217]) by cmsmtp with ESMTPSA id fMbTtNqCsJhBPfMbUt2jYI; Tue, 04 Feb 2025 17:20:52 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=QY3Fvdbv c=1 sm=1 tr=0 ts=67a24c74 a=h7br+8Ma+Xn9xscxy5znUg==:117 a=h7br+8Ma+Xn9xscxy5znUg==:17 a=kj9zAlcOel0A:10 a=T2h4t0Lz3GQA:10 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=YxBL1-UpAAAA:8 a=iaO6b-da03RWclYSbCMA:9 a=CjuIK1q_8ugA:10 a=LK5xJRSDVpKd5WXXoEvA:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id A808F64; Tue, 04 Feb 2025 09:20:50 -0800 (PST) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 8EA2C281; Tue, 04 Feb 2025 09:11:21 -0800 (PST) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Ed Maste cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: ecccb638d494 - main - mountd: Promote missing netmask log to LOG_ERR In-reply-to: <202502041658.514Gwo4I049201@gitrepo.freebsd.org> References: <202502041658.514Gwo4I049201@gitrepo.freebsd.org> Comments: In-reply-to Ed Maste message dated "Tue, 04 Feb 2025 16:58:50 +0000." List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 04 Feb 2025 09:11:21 -0800 Message-Id: <20250204171121.8EA2C281@slippy.cwsent.com> X-CMAE-Envelope: MS4xfDwYVEEbXW3Z85u6k6ynXCISDif8iNxIquCBSrKxkJBOeustRP7tI5SW6Raq5tydSHGxkFXe6LkZyiR8ShQfQt0HCa75KuziTDkmlxE2L339YHzQUvIU nMTagAhJ+V1UAteIWdqME4YKtDxIYePkdvzF02rylM2p9XKqRvQzzy52GYu3F1ouaHpScD5UvYtBR2aXp+l0WEDI6feDcJUdVZLoPzdWMeUBu9OzpI1k4cm1 wSENOgAltIRDnqIo3GovQ+S2YHLcd9/I27Bn/VvJRXr557jp43XsDmvZMrIcFJQ7EUeTzAP62BqQXEki8V/5PRwiRggf5bq+qjGK3h0owu4= X-Rspamd-Queue-Id: 4YnVWT12ktz3W8m X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] In message <202502041658.514Gwo4I049201@gitrepo.freebsd.org>, Ed Maste writes: > The branch main has been updated by emaste: > > URL: https://cgit.FreeBSD.org/src/commit/?id=ecccb638d494f2642f1e2eae8ad932ba > 70567ccc > > commit ecccb638d494f2642f1e2eae8ad932ba70567ccc > Author: Ed Maste > AuthorDate: 2025-02-01 13:16:47 +0000 > Commit: Ed Maste > CommitDate: 2025-02-04 16:58:41 +0000 > > mountd: Promote missing netmask log to LOG_ERR > > Historical network classes are deprecated, but currently still supported > in mountd with a LOG_WARNING-priority message added by Mike Karels in > 2021. Upgrade the log to LOG_ERR well in advance of this becoming a > fatal error. > > Reviewed by: rmacklem > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D48795 > --- > usr.sbin/mountd/mountd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/usr.sbin/mountd/mountd.c b/usr.sbin/mountd/mountd.c > index 4457a925c2ed..19d76b72da10 100644 > --- a/usr.sbin/mountd/mountd.c > +++ b/usr.sbin/mountd/mountd.c > @@ -1806,7 +1806,7 @@ get_exportlist_one(int passno) > len = endcp - cp; > } > if (opt_flags & OP_CLASSMASK) > - syslog(LOG_WARNING, > + syslog(LOG_ERR, > "WARNING: No mask specified for %s, " Should this be changed from WARNING to ERROR too? > "using out-of-date default", > (&grp->gr_ptr.gt_net)->nt_name); > -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0