From nobody Mon Sep 15 19:26:02 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cQZl245Htz67vkk; Mon, 15 Sep 2025 19:26:06 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cQZl23VYkz4Lt9; Mon, 15 Sep 2025 19:26:06 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757964366; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yLCpkVcr2NRCTIkbzm1omgfwEG2vZoQ6wOK3X6SCdRU=; b=rqPIv258acT23qfukEPKB9b+LnPp7JOt55N4Xw3vT1fXDCu+YjdfeSuO4tHEmos0sFdAPt gc+m4aqMdPJfVLjnrVx0LgEU0yIl/J/heY0ycMe/aBiVhtW+q/KZWltqVlB+3EWdpQ1BVj DeUraVT4/0mcYPmXM142UBmCcLgf8f0gUNwIEtaRRZwZvbZ9C2PBl9RQ+LZ9Dce297ddS1 u04HjdcjCgBYvkazXgRojjlpsj15gnx6rWQ9Oxgk6iR4lVAYHtNAYFJ24r0vCtQAVURwXG BwAIb9HzxCdFo+Y9bnUg1a+sBp4GGj+yaeu2ga8zpmm1jsKwMexLkffbAgqWNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757964366; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yLCpkVcr2NRCTIkbzm1omgfwEG2vZoQ6wOK3X6SCdRU=; b=krFsDRNvxMp2qKwTOadDiHnCvy6fhwG16cPs31Y8kvy6UdErLDVn9kMimAMcmjMvv5dTZZ yxCGiA9ApCswjGIjhFw/MNT4dvqKLWerUQTedIuPlLKdtdPgKUxrp4DHLQXr3Hft4NMbBJ 9t+gK35fB7tsTDbKul7Joqree4zyhJnbbNKnktbLS8qTr77zdJ5xSuaAZTd9CaAw9xwOUA TWcK5lx7aHYa8fK5XiThCti0vRWuxMHnkOZ7G/s6XLp3VdHG0bI3Zo0kp55S09e5RqVF3H 4gP0S77Byq+f/YJj62czFtDyf/Ws33BE6FfdvP+tNW7zjuMetOQ5fi8jsI4x5Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1757964366; a=rsa-sha256; cv=none; b=xAOVaMOgWNJVMci6adr2UbFKcrqvTGkKO1eJ6N1CtUzEYToIRgUbsEuIuyHmJLZVVjhjnR iny72ijL53WsDxy9PdxI3LiNhzM+cu+RhqH8hppLg9uhipVtkqjMeAOEiKgKm6T08A4xCF D4u9tH11PXE31tj/MBrszCoIZFNQp28n50VR/be/TCP7Ch/8iRibYDZIQs3xQxMGXvbnl6 6TVbOLW3Hg1RxmT4t812y4fX2SYhxAulXIY+Q9DVyonzTl1HvzMmcwNexJ9Gcao28mlxpg NiHEOW+94xx6DUesAYueeWAhvQw8xCkE/rQy/hcKBOas7RgygY8fFkq+4Wf2Ug== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "E6" (verified OK)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cQZl220YSzc2; Mon, 15 Sep 2025 19:26:06 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id ED1ABA64805; Mon, 15 Sep 2025 19:25:55 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 707552D029E6; Mon, 15 Sep 2025 19:26:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id fTgPfo-Os28w; Mon, 15 Sep 2025 19:26:03 +0000 (UTC) Received: from strong-iwl0.sbone.de (strong-iwl0.sbone.de [IPv6:fde9:577b:c1a9:4902:a66b:b6ff:fe40:39a9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id D55462D029D8; Mon, 15 Sep 2025 19:26:02 +0000 (UTC) Date: Mon, 15 Sep 2025 19:26:02 +0000 (UTC) From: "Bjoern A. Zeeb" To: Warner Losh , =?UTF-8?Q?Jean-S=C3=A9bastien_P=C3=A9dron?= cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 5e0a4859f28a - main - iwlwifi: Don't compile for gcc before 14 In-Reply-To: <202509150304.58F34BWJ035102@gitrepo.freebsd.org> Message-ID: References: <202509150304.58F34BWJ035102@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII On Mon, 15 Sep 2025, Warner Losh wrote: > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=5e0a4859f28ad4869f7a73faf42debc355a370bf > > commit 5e0a4859f28ad4869f7a73faf42debc355a370bf > Author: Warner Losh > AuthorDate: 2025-09-14 18:03:16 +0000 > Commit: Warner Losh > CommitDate: 2025-09-15 03:03:45 +0000 > > iwlwifi: Don't compile for gcc before 14 > > gcc 13 and earlier don't have __builtin_bitcountg. The linux wifi kpi > uses this unconditionally. While in this one use, it might not be > needed, I opted to not compile iwlwifi when building gcc12 or 13 rather > than risk breaking it for everbody else. > > With this change gcc12 builds the kernel. Maybe this will stop jenkins > email for every commit I make. > > Sponsored by: Netflix > --- > sys/modules/Makefile | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/sys/modules/Makefile b/sys/modules/Makefile > index 5315d518afd8..f9fdbca78869 100644 > --- a/sys/modules/Makefile > +++ b/sys/modules/Makefile > @@ -576,7 +576,10 @@ _mlx5ib= mlx5ib > ${MACHINE_CPUARCH} == "i386" > _ena= ena > _gve= gve > +# gcc13 and earlier lack __builtin_bitcountg used by linux emulation (a) I beleive there is no __builtin_bitcountg but you mean __builtin_popcountg both here and in the commit message. (b) That was introduced in 7cbc4d875971860d941cc15d7f42e6cfeffbfe66 for DRM (c) There is no direct use in any LinuxKPI based wireless driver: % grep -r __builtin_popcountg sys/contrib/dev % (4) iwlwifi only uses HWEIGHT32, which was changed by the aforementioned commit in LinuxKPI. (5) Please do it right and in the place where it is actually defined to be used, in LinuxKPI, and not here as it can be easily fixed there with an #ifdef or otherwise as there were alternatives on the review if I remember correctly. I am Cc:ing dumbbell as well as he needed the change for DRM. PS: we also need to fix this in sys/sys at some point and save us some trouble. > +.if !(${COMPILER_TYPE} == "gcc" && ${COMPILER_VERSION} < 140000) > _iwlwifi= iwlwifi > +.endif > _rtw88= rtw88 > _rtw89= rtw89 > _vmware= vmware > -- Bjoern A. Zeeb r15:7