From owner-freebsd-current@freebsd.org Tue Jul 5 18:52:55 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A3441B20954 for ; Tue, 5 Jul 2016 18:52:55 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 67B401E0D; Tue, 5 Jul 2016 18:52:55 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [IPv6:2001:7b8:3a7::790d:41fc:f7ec:2cb2] (unknown [IPv6:2001:7b8:3a7:0:790d:41fc:f7ec:2cb2]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id D6B6B43B0D; Tue, 5 Jul 2016 20:52:50 +0200 (CEST) Subject: Re: FreeBSD_HEAD_amd64_gcc - Build #1340 - Still Failing Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_AED8B5FE-73A7-43E5-A8C8-26E8D4724608"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.6b2 (ebbf3ef) From: Dimitry Andric In-Reply-To: <824400089.31.1467734600930.JavaMail.jenkins@jenkins-9.freebsd.org> Date: Tue, 5 Jul 2016 20:52:42 +0200 Cc: Roman Divacky Message-Id: <1A4CCE99-7039-404C-B177-1DA230AD8811@FreeBSD.org> References: <74935894.29.1467723929184.JavaMail.jenkins@jenkins-9.freebsd.org> <824400089.31.1467734600930.JavaMail.jenkins@jenkins-9.freebsd.org> To: freebsd-current@FreeBSD.org X-Mailer: Apple Mail (2.3124) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jul 2016 18:52:55 -0000 --Apple-Mail=_AED8B5FE-73A7-43E5-A8C8-26E8D4724608 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 05 Jul 2016, at 18:03, jenkins-admin@freebsd.org wrote: >=20 > FreeBSD_HEAD_amd64_gcc - Build #1340 - Still Failing: >=20 > Build information: = https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_amd64_gcc/1340/ > Full change log: = https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_amd64_gcc/1340/changes > Full build log: = https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_amd64_gcc/1340/console ... > /builds/FreeBSD_HEAD_amd64_gcc/usr.sbin/bhyve/rfb.c: In function = 'sse42_supported': > /builds/FreeBSD_HEAD_amd64_gcc/usr.sbin/bhyve/rfb.c:885:17: error: = 'bit_SSE42' undeclared (first use in this function) > return ((ecx & bit_SSE42) !=3D 0); > ^ So, this is because clang's and gcc's versions of cpuid.h use slightly = different naming for these bits: clang's cpuid.h: #define bit_SSE41 0x00080000 #define bit_SSE42 0x00100000 gcc's cpuid.h: #define bit_SSE4_1 (1 << 19) #define bit_SSE4_2 (1 << 20) Unfortunately there are more bit defines that differ. No = standardization on this point, it seems. :-/ For this specific compile error, we could put in a little crutch like: #if defined(bit_SSE4_2) && !defined(bit_SSE42) #define bit_SSE42 bit_SSE4_2 #endif Thoughts? -Dimitry --Apple-Mail=_AED8B5FE-73A7-43E5-A8C8-26E8D4724608 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.30 iEYEARECAAYFAld8AgIACgkQsF6jCi4glqOapgCcC3v9txvrsrusVLR3eX1zdtxM TbMAnjTixK0yKeWSB72IpshlJlGlM3Fu =I8s+ -----END PGP SIGNATURE----- --Apple-Mail=_AED8B5FE-73A7-43E5-A8C8-26E8D4724608--