From owner-freebsd-current Wed Apr 19 22:19:42 2000 Delivered-To: freebsd-current@freebsd.org Received: from lynx.aba.net.au (lynx.esec.com.au [203.21.84.1]) by hub.freebsd.org (Postfix) with SMTP id D58F937B59B for ; Wed, 19 Apr 2000 22:19:38 -0700 (PDT) (envelope-from tim@esec.com.au) Received: (qmail 19824 invoked from network); 20 Apr 2000 05:16:16 -0000 Received: from feline.esec.com.au (203.21.85.202) by lynx.esec.com.au with SMTP; 20 Apr 2000 05:16:16 -0000 Received: from esec.com.au (localhost [127.0.0.1]) by feline.esec.com.au (8.9.3/8.9.3) with ESMTP id PAA24428; Thu, 20 Apr 2000 15:21:46 +1000 (EST) (envelope-from tim@esec.com.au) Message-ID: <38FE93E9.656E5306@esec.com.au> Date: Thu, 20 Apr 2000 15:21:46 +1000 From: Tim Liddelow Organization: eSec Ltd X-Mailer: Mozilla 4.72 [en] (X11; I; Linux 2.2.12 i386) X-Accept-Language: en MIME-Version: 1.0 To: "Eric D. Futch" Cc: freebsd-current@freebsd.org Subject: Re: FTP_PASSIVE_MODE and libftpio References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG "Eric D. Futch" wrote: > > > Please take a look at the PR I put together bin/18103 and let me know if > this is a good (enough) fix for the problem. > > The patch can aslo be found at: > http://quake.nyct.net/~efutch/FreeBSD/ftpio.c.patch Looking at the patch, the only mod I would suggest is to preserve the current behaviour; make it set passive mode if the variable is just defined (without any value). If it is NO, sure, dont set passive mode, but set passive mode if the variable is YES or no value. i.e. looking at the patch, change the last if statement to just if (cp) and don't do the strncmp(). Just my $0.02. Cheers Tim. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message