Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 20 Aug 2012 22:52:30 GMT
From:      Artis Caune <Artis.Caune@gmail.com>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/170811: [PATCH]: fix ports option for multiple ports without maintainers
Message-ID:  <201208202252.q7KMqUbE064608@red.freebsd.org>
Resent-Message-ID: <201208202300.q7KN0PMd048312@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         170811
>Category:       ports
>Synopsis:       [PATCH]: fix ports option for multiple ports without maintainers
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Aug 20 23:00:25 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Artis Caune
>Release:        stable/9
>Organization:
>Environment:
FreeBSD freebsd 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE r239148: Fri Aug 10 00:00:00 UTC 2012 root@freebsd:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
There are typos in Makefile for the following ports:
    games/evq3
    games/abe
    audio/jokosher
    deskutils/kdepim3
    print/pnm2ppa

patch is agains /usr/ports directory!

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- games/evq3/Makefile.orig	2012-08-21 10:38:17.920196125 +1200
+++ games/evq3/Makefile	2012-08-21 10:39:16.110192507 +1200
@@ -66,7 +66,7 @@
 .   if ${PORT_OPTIONS:MCURL}
 LIB_DEPENDS+=	curl.6:${PORTSDIR}/ftp/curl
 MAKE_ENV+=	USE_CURL=1
-.       if ${PORT_OPTIONS:MCURL_DLOPEN)
+.       if ${PORT_OPTIONS:MCURL_DLOPEN}
 MAKE_ENV+=	USE_CURL_DLOPEN=1
 .       endif
 .   endif
@@ -74,7 +74,7 @@
 .   if ${PORT_OPTIONS:MOPENAL}
 USE_OPENAL=	al
 MAKE_ENV+=	USE_OPENAL=1
-.       if ${PORT_OPTIONS:MOPENAL_DLOPEN)
+.       if ${PORT_OPTIONS:MOPENAL_DLOPEN}
 MAKE_ENV+=	USE_OPENAL_DLOPEN=1
 .       endif
 .   endif
--- games/abe/Makefile.orig	2012-08-21 10:39:28.280193818 +1200
+++ games/abe/Makefile	2012-08-21 10:40:33.632156760 +1200
@@ -37,13 +37,13 @@
 
 .include <bsd.port.options.mk>
 
-.if ${PORT_OPTIONS:MGOD_MODE} || !empty{PORT_OPTIONS:MOPTIMIZED_CFLAGS}
+.if ${PORT_OPTIONS:MGOD_MODE} || !empty(PORT_OPTIONS:MOPTIMIZED_CFLAGS)
 post-patch:
 .   if ${PORT_OPTIONS:MGOD_MODE}
 	@${REINPLACE_CMD} -e 's|\(#define GOD_MODE\) 0|\1 1|' \
 		${WRKSRC}/src/Game.h
 .   endif
-.   if empty(PORT_OPTIONS:MOPTIMIZED_CFLAGS}
+.   if empty(PORT_OPTIONS:MOPTIMIZED_CFLAGS)
 	@${REINPLACE_CMD} -e 's|-O2||g ; \
 		s|-fomit-frame-pointer||g ; \
 		s|-ffast-math||g ; \
--- audio/jokosher/Makefile.orig	2012-08-21 10:40:52.880193119 +1200
+++ audio/jokosher/Makefile	2012-08-21 10:41:28.810191104 +1200
@@ -60,7 +60,7 @@
 .endif
 
 .for plugin in flac gconf jack ladspa lame mp3 pulse vorbis
-. if ${PORT_OPTIONS:M${plugin:U})
+. if ${PORT_OPTIONS:M${plugin:U}}
 USE_GSTREAMER+=${plugin}
 . endif
 .endfor
--- deskutils/kdepim3/Makefile.orig	2012-08-21 10:41:56.800207682 +1200
+++ deskutils/kdepim3/Makefile	2012-08-21 10:42:33.471593965 +1200
@@ -59,7 +59,7 @@
 .	endif
 .endif
 
-.if ${PORT_OPTIONS:MGNOKII)
+.if ${PORT_OPTIONS:MGNOKII}
 LIB_DEPENDS+=	gnokii:${PORTSDIR}/comms/gnokii
 .endif
 
--- print/pnm2ppa/Makefile.orig	2012-08-21 10:42:52.695129238 +1200
+++ print/pnm2ppa/Makefile	2012-08-21 10:43:22.060199961 +1200
@@ -29,7 +29,7 @@
 
 .include <bsd.port.pre.mk>
 
-.if defined(A4) || !empty(PORT_OPTIONS:MA4SIZE}
+.if defined(A4) || !empty(PORT_OPTIONS:MA4SIZE)
 RUN_DEPENDS=	enscript:${PORTSDIR}/print/enscript-a4
 .else
 RUN_DEPENDS=	enscript:${PORTSDIR}/print/enscript-letter


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201208202252.q7KMqUbE064608>