From owner-freebsd-bugs@FreeBSD.ORG Wed Sep 29 18:20:26 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CB13B16A4D3 for ; Wed, 29 Sep 2004 18:20:26 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5D06443D45 for ; Wed, 29 Sep 2004 18:20:26 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i8TIKQpP092953 for ; Wed, 29 Sep 2004 18:20:26 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i8TIKQbk092943; Wed, 29 Sep 2004 18:20:26 GMT (envelope-from gnats) Resent-Date: Wed, 29 Sep 2004 18:20:26 GMT Resent-Message-Id: <200409291820.i8TIKQbk092943@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Doug Haigh Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0E00D16A4CE for ; Wed, 29 Sep 2004 18:16:17 +0000 (GMT) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 02B7A43D62 for ; Wed, 29 Sep 2004 18:16:17 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.12.11/8.12.11) with ESMTP id i8TIGGpe008265 for ; Wed, 29 Sep 2004 18:16:16 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.12.11/8.12.11/Submit) id i8TIGG39008264; Wed, 29 Sep 2004 18:16:16 GMT (envelope-from nobody) Message-Id: <200409291816.i8TIGG39008264@www.freebsd.org> Date: Wed, 29 Sep 2004 18:16:16 GMT From: Doug Haigh To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Subject: bin/72177: camcontrol's getdevtree fails X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Sep 2004 18:20:27 -0000 >Number: 72177 >Category: bin >Synopsis: camcontrol's getdevtree fails >Confidential: no >Severity: serious >Priority: high >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Sep 29 18:20:25 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Doug Haigh >Release: 5.2.1 >Organization: >Environment: Environment independent - error in base code for /sbin/camcontrol >Description: On SPARC64 machine, running the camcontrol devlist command fails because the xptioctl code thinks the physical flag (CAM_DATA_PHYS) is set. In looking into /usr/src/sbin/camcontrol/camcontrol.c in the getdevtree routine, the CCB union is allocated off the stack, but the bzero command to clear out the structure skips the header section and just clears the ccb_dev_match part. Because of this, whatever is on the stack is sent as header flags to the ioctl routine. I would suggest clearing out the entire strucure or explicitly setting all fields in the header structure. >How-To-Repeat: Difficult to do unless you can mess up the stack data to imitate the CAM_DATA_PHYS being set. >Fix: Change line 306 from bzero(&(&ccb.ccb_h)[1], sizeof(struct ccb_dev_match) - sizeof(struct ccb_hdr)); to bzero(&ccb, sizeof(ccb)); >Release-Note: >Audit-Trail: >Unformatted: