From owner-svn-src-head@freebsd.org Mon Aug 29 18:45:39 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 98022BC32F1 for ; Mon, 29 Aug 2016 18:45:39 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-lf0-f44.google.com (mail-lf0-f44.google.com [209.85.215.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 26F492924 for ; Mon, 29 Aug 2016 18:45:38 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by mail-lf0-f44.google.com with SMTP id f93so107307466lfi.2 for ; Mon, 29 Aug 2016 11:45:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=6PlFIDxusg+JsGmaBt64M85Egw6mA/sIVpDZc2Xcndw=; b=cezqLOMkjx8yW0AKhLFULLyJslRdxvN6T8nH1yQYBgN/tVilPl6u8Ti6L87s3pGTww isk3jdnQpiuY0+ULSooHc07CekIF2ialdJgM7a+jdmz2QJRkw4Yw+IWcmkq2NIOe7dzL t4Tl9fCgBgYcL5WbrRoXEhFkmHE5cbpaxjEuwCTI3QZMSY4+G+LOGzkvE8ljiaS04nqr q6MSPRayShf1mDgxI+uyNOUToUc+xM9QnQKm5N9gtCOSeD5w45TpPBoCpe0GSanz61ED v9hdqZDHSMp7VQuy8IhMqlIPk1x6fRZxoXZCLSD0pXP1UzAwthJdrSPiubnfIpjFG/6B XojQ== X-Gm-Message-State: AE9vXwO0znqPDa7r1XooAKg8wXTAZ7YBc51x79xIrjfxXd02P7wlHXfVwN+8Jytgle4OFA== X-Received: by 10.25.131.141 with SMTP id f135mr4679013lfd.217.1472496336100; Mon, 29 Aug 2016 11:45:36 -0700 (PDT) Received: from [192.168.1.2] ([89.169.173.68]) by smtp.gmail.com with ESMTPSA id p128sm6675875lfb.32.2016.08.29.11.45.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Aug 2016 11:45:35 -0700 (PDT) Subject: Re: svn commit: r304928 - in head/lib/libc: amd64/sys i386/sys sys To: Konstantin Belousov , John Baldwin References: <201608272303.u7RN3N0D078505@repo.freebsd.org> <1595604.93PBdSz0kX@ralph.baldwin.cx> <20160829065813.GP83214@kib.kiev.ua> <18206408.GMLM77D01s@ralph.baldwin.cx> <20160829180454.GU83214@kib.kiev.ua> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Andrey Chernov Message-ID: Date: Mon, 29 Aug 2016 21:45:33 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Aug 2016 18:45:39 -0000 On 29.08.2016 21:16, Andrey Chernov wrote: > On 29.08.2016 21:04, Konstantin Belousov wrote: >> On Mon, Aug 29, 2016 at 08:46:47PM +0300, Andrey Chernov wrote: >>> Either we implement this wrapper or left all things as is, we need to >>> document internal errno clearing additionally, to not make people wonder >>> why errno becomes 0, probably with the mention that program should not >>> relay on this obsoleted implementation feature. >> It was done in r304928. John want to revert this change, it seems. >> > Previous text is documented everywhere and describing usual good > practice, so it should remains in place, in that means r304928 should be > reverted, because replace proper way of doing things with obsoleted > feature description. > > What I suggest is not _replace_ old text with new, but _add_ new text as > describing current and not recommended way, with the direct mention that > this feature is obsoleted and not recommended for relay on it. I.e. add to old text something like this (my English is bad, so it probably needs correction): "Currently ptrace(2) always set errno to 0 at the start, but portable program should not relay on this obsoleted feature".