From owner-freebsd-firewire@FreeBSD.ORG Fri Aug 29 21:02:52 2008 Return-Path: Delivered-To: freebsd-firewire@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8CDFF1065687 for ; Fri, 29 Aug 2008 21:02:52 +0000 (UTC) (envelope-from sbruno@miralink.com) Received: from plato.miralink.com (mail.miralink.com [70.103.185.20]) by mx1.freebsd.org (Postfix) with ESMTP id 695388FC0A for ; Fri, 29 Aug 2008 21:02:52 +0000 (UTC) (envelope-from sbruno@miralink.com) Received: from localhost (localhost.localdomain [127.0.0.1]) by plato.miralink.com (Postfix) with ESMTP id 0C3051A91B6; Fri, 29 Aug 2008 13:53:06 -0700 (PDT) X-Virus-Scanned: amavisd-new at X-Spam-Flag: NO X-Spam-Score: -4.354 X-Spam-Level: X-Spam-Status: No, score=-4.354 tagged_above=-10 required=6.6 tests=[ALL_TRUSTED=-1.8, AWL=0.046, BAYES_00=-2.599] Received: from plato.miralink.com ([127.0.0.1]) by localhost (plato.miralink.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aovmx9JSpGbx; Fri, 29 Aug 2008 13:53:05 -0700 (PDT) Received: from [10.0.0.40] (iago.office.miralink.com [10.0.0.40]) by plato.miralink.com (Postfix) with ESMTP id 4E46D1A91A0; Fri, 29 Aug 2008 13:53:05 -0700 (PDT) Message-ID: <48B863FB.10202@miralink.com> Date: Fri, 29 Aug 2008 14:02:51 -0700 From: Sean Bruno User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: Dieter References: <200808292021.UAA25442@sopwith.solgatos.com> In-Reply-To: <200808292021.UAA25442@sopwith.solgatos.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-firewire@freebsd.org Subject: Re: This is where I'm going with fwcontrol X-BeenThere: freebsd-firewire@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Firewire support in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Aug 2008 21:02:52 -0000 Dieter wrote: >>> Should >>> >>> >>> >>>> Message ID Root ID R T Gap Count >>>> 00(2 bits) (5 bits) 1 1 (6 bits) >>>> >>>> >>> >>> be >>> >>> Message ID Root ID R T Gap Count >>> 00(2 bits) (6 bits) 1 1 (6 bits) >>> >>> send_phy_config() ANDs root_node with 0x3f, and the >>> "Physical ID" field in the controller register is >>> 6 bits. >>> >>> >> Well, according to the 1394 documentation, no. The root ID is >> definitely 5 bits. >> >> The gap count is also 5 bits, I must have mis-counted. So, really it >> should be: >> >> Message ID Root ID R T Gap Count >> 00(2 bits) (5 bits) 1 1 (5 bits) >> > > Looking at "Table 5. PHY Register Map" in the VIA controller datasheet > (page 24 of the pdf) > http://www.datasheetarchive.com/pdf-datasheets/Datasheets-6/DSA-113181.pdf > > the "Physical ID" field is 6 bits, as is the "Gap Count" field. > I don't have the IEEE documentation, so I'll have to assume > you are correct about it saying 5 bits. So why doesn't the > controller datasheet agree with the IEEE doc? Granted one is > a controller register and the other is a packet, but I'd > expect these individual fields to be the same size. > > >> This means that the Root ID and the Gap Count cannot exceed 0x3f(63). >> > > That's 6 bits. 5 bits would be 0x1f = 31 decimal. > > Huh....I seem to be having some kind of wierd PDF rendering issue. Ok, so looking at the document in another application(not acroread), the Node ID is 6 bits, the Gap Count is 6 bits. I'm the crazy one I guess. Wierd. >> So, the masking >> of the values instead of generating and error seems wrong to me. I'm >> going to put in error checking >> to make sure the values comply with the specification and document the >> correct values in the man page >> and the comments of the code. >> > > Sounds good. > -- Sean Bruno MiraLink Corporation 6015 NE 80th Ave, Ste 100 Portland, OR 97218 Phone 503-621-5143 Fax 503-621-5199 MSN: sbruno@miralink.com Google: seanwbruno@gmail.com Yahoo: sean_bruno@yahoo.com