Date: Sun, 22 Jul 2012 22:15:21 -0500 From: Jeremy Messenger <mezz.freebsd@gmail.com> To: Doug Barton <dougb@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r301362 - in head: archivers/libcomprex audio/libmtp audio/libsidplay2 cad/adms databases/dbh10 databases/mysqlcppapi devel/bufferpool devel/clanlib devel/compiz-bcop devel/dotconf deve... Message-ID: <CADLFttfb=CrYZnUWDJos14sCRF56uJA5HUhe-4=AndUeVki=Xw@mail.gmail.com> In-Reply-To: <500CB0F7.2090601@FreeBSD.org> References: <201207230133.q6N1XumG049975@svn.freebsd.org> <CADLFttddeu_7H3KwLbzqPJcKKoT6GNhngv61QFz11t0_Qz9Wdw@mail.gmail.com> <500CB0F7.2090601@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jul 22, 2012 at 9:03 PM, Doug Barton <dougb@freebsd.org> wrote: > On 07/22/2012 18:47, Jeremy Messenger wrote: >> On Sun, Jul 22, 2012 at 8:33 PM, Doug Barton <dougb@freebsd.org> wrote: >>> Author: dougb >>> Date: Mon Jul 23 01:33:55 2012 >>> New Revision: 301362 >>> URL: http://svn.freebsd.org/changeset/ports/301362 >>> >>> Log: >>> For ports maintained by ports@ where pkgconfig is one of the USE_GNOME deps >>> convert it to BUILD_DEPENDS. This avoids the problem of the bogus run dep >>> added by bsd.gnome.mk. >> <snip> >> >> You should wait for bapt@ on this one. He is going to work on USE_PKGCONFIG. > > If bapt's solution materializes, and if it's appropriate for these > particular ports, then it can still be utilized. The only thing that is > different now is that these ports match a different grep pattern, one > that will have to be searched for anyway. > > IOW, this change doesn't hurt anything long term, and it does solve the > bogus run-dep problem now. It doesn't hurt, but you are making more work for bapt by chase all of your change. bapt wants to add WANT_PKGCONFIG to allow us to choice either pkg-config or pkgconf, so that line will be changed either. > Oh, and for this set of ports removing USE_GNOME is a double feature, > since it didn't need to be included there in the first place. > > Doug > > -- > > Change is hard. -- mezz.freebsd@gmail.com - mezz@FreeBSD.org FreeBSD GNOME Team http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLFttfb=CrYZnUWDJos14sCRF56uJA5HUhe-4=AndUeVki=Xw>