From owner-cvs-src-old@FreeBSD.ORG Sun Jun 21 10:10:57 2009 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B65A01065760 for ; Sun, 21 Jun 2009 10:10:57 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A29B38FC18 for ; Sun, 21 Jun 2009 10:10:57 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n5LAAvfn078440 for ; Sun, 21 Jun 2009 10:10:57 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n5LAAvhk078439 for cvs-src-old@freebsd.org; Sun, 21 Jun 2009 10:10:57 GMT (envelope-from rwatson@repoman.freebsd.org) Message-Id: <200906211010.n5LAAvhk078439@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to rwatson@repoman.freebsd.org using -f From: Robert Watson Date: Sun, 21 Jun 2009 10:10:44 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netipx README ipx_input.c ipx_outputfl.c ipx_var.h X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Jun 2009 10:10:58 -0000 rwatson 2009-06-21 10:10:44 UTC FreeBSD src repository Modified files: sys/netipx README ipx_input.c ipx_outputfl.c ipx_var.h Log: SVN rev 194580 on 2009-06-21 10:10:44Z by rwatson Remove historical support for capturing IPX packets in the output path using raw IPX sockets. While functional, this support is disabled using a flag that can't be changed from userspace, and google reveals no documentation or use of that flag anywhere. This eliminates a potential lock order reversal and code reentrance issue in which the output path reentered the input path in IPX. An alternative to removal would be to use the netisr, as a comment I added in 2005 suggests. While this change is fairly straight-forward, the lack of any consumers or the easy possibility of consumers (kernel modification and recompile required) suggests that this is simply an unused feature. Update README to remove this TODO, and a TODO regarding IPX/IP encapsulation which was also removed a few years ago. MFC after: 1 week Revision Changes Path 1.9 +0 -8 src/sys/netipx/README 1.62 +0 -50 src/sys/netipx/ipx_input.c 1.26 +0 -8 src/sys/netipx/ipx_outputfl.c 1.25 +0 -1 src/sys/netipx/ipx_var.h