From nobody Tue May 20 14:57:13 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4b1yMF4H32z5wW99; Tue, 20 May 2025 14:57:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4b1yMF3kf3z3kfl; Tue, 20 May 2025 14:57:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747753033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fZ6fVzxGFtvF1KSAQbzB/kTLDwKisNMl25lxWW7xsmc=; b=FBiHm9bmVqdMVZxCFdKQtiHCphoguKm0DSEdjRmXITlPaPtsySgvXGg37lpMQ5QohWIBJk pK6Y5jX7H6p6kimRMMfBNzZYr/flrlMyojSA7kr7WpJxiStkx3HzvsuycHEYUrxCYHoKCy s5rgw66VUw671cLtq+yVJtLOoyjjum0Qc1hSxHwCuZQrdMKUYZQnIL8y8fQP/+fLbotBve x4dRjfdEdUIKHuL0OpghOpQbCOkTFai/1IjFYtrIXVrn/2ZEJIAyJtHVJgUf4GBnO6trkG ZQKcK2S+SJlR3dnBzfI/fVuTkYOGzvi9z4UjkX9hHw17bjs6VSsgWs/QV2cOOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747753033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fZ6fVzxGFtvF1KSAQbzB/kTLDwKisNMl25lxWW7xsmc=; b=ok5IuOTMNYrYp/yJA4Va+PutgmhKU+DfwudyYNgCEZ+Afb+cGCQaKmX8kXPQ3h2zddeJV0 TuNiTAgRr76q7CHObvbftkOxx0MNsa4DD2RQVs5KK5iJJaAzDH4pCtU/croaUGzMRNSiiK ptUzbLHZ/I6JnC6XJXb+qLiXFUmB4DrjnJCIlpyYRcxyC6gYFI4LrN4PRvP9CvNB4wn1ux TCCoTRHE0yu7YCaAOLfciTPWqkTHUxYePJJrkw4O7YiexagscQbjtVYAi/IlxwYHUA5sP0 iecHQjAdiS9MaYl2v+7WANdweWJWsSwziDxSVyLgO1EoMETfvNaCGVup80EKeg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1747753033; a=rsa-sha256; cv=none; b=KAxba/NzE7qgTXHzSvd2010OJXb4ssDigJho1GoSFC/CtvnSi1FmQkPpTog2bxL/cYhMKU PF5Wo1zFNcUWwt5tYanwTgZkEi0aOBsjBzwOYye7wsMXs1OOizvDRlx4DSSDDug9xc2QBe YIC3l+EBlq6qEhTr39r567un4/uuy701CSRD6yLIPHDOeOFVrg/aGdIY9BTqH2/itJJtvl xeHbMd/K0gWjqLf7PZTzupLULYsfGdm/PIr4d0TKV7HnqO1wj6Z2dMH6Hs9/t8Wpr4Hf4o ZIlPNzgbyU1nhRx+rx6HtnvJEWrLO5WGE7A8E6Pq2ayBWAon5UPh9U2vOMbb5A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4b1yMF3K0Kzv7t; Tue, 20 May 2025 14:57:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 54KEvDMn053954; Tue, 20 May 2025 14:57:13 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 54KEvD1r053951; Tue, 20 May 2025 14:57:13 GMT (envelope-from git) Date: Tue, 20 May 2025 14:57:13 GMT Message-Id: <202505201457.54KEvD1r053951@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andriy Gapon Subject: git: 0d2fd5b99c95 - main - ns8250: use LSR_THRE instead of LSR_TEMT for checking tx flush List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: avg X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0d2fd5b99c95329085d0700a4dd38507a054a50d Auto-Submitted: auto-generated The branch main has been updated by avg: URL: https://cgit.FreeBSD.org/src/commit/?id=0d2fd5b99c95329085d0700a4dd38507a054a50d commit 0d2fd5b99c95329085d0700a4dd38507a054a50d Author: Andriy Gapon AuthorDate: 2024-11-10 11:15:30 +0000 Commit: Andriy Gapon CommitDate: 2025-05-20 14:55:18 +0000 ns8250: use LSR_THRE instead of LSR_TEMT for checking tx flush LSR_TEMT bit is set if both transmit hold and shift registers are empty, but the flush command flushes only the hold register. While here, update the diagnostic message to report which registers could not be flushed. MFC after: 2 weeks --- sys/dev/uart/uart_dev_ns8250.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/uart/uart_dev_ns8250.c b/sys/dev/uart/uart_dev_ns8250.c index 1df39b499539..0f19ede6d9df 100644 --- a/sys/dev/uart/uart_dev_ns8250.c +++ b/sys/dev/uart/uart_dev_ns8250.c @@ -265,12 +265,12 @@ ns8250_flush(struct uart_bas *bas, int what) * https://github.com/rust-vmm/vm-superio/issues/83 */ lsr = uart_getreg(bas, REG_LSR); - if (((lsr & LSR_TEMT) == 0) && (what & UART_FLUSH_TRANSMITTER)) + if (((lsr & LSR_THRE) == 0) && (what & UART_FLUSH_TRANSMITTER)) drain |= UART_DRAIN_TRANSMITTER; if ((lsr & LSR_RXRDY) && (what & UART_FLUSH_RECEIVER)) drain |= UART_DRAIN_RECEIVER; if (drain != 0) { - printf("uart: ns8250: UART FCR is broken\n"); + printf("uart: ns8250: UART FCR is broken (%#x)\n", drain); ns8250_drain(bas, drain); } }