From nobody Fri Feb 10 07:29:33 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PClk65wVqz3nrjT for ; Fri, 10 Feb 2023 07:29:50 +0000 (UTC) (envelope-from Alexander@leidinger.net) Received: from mailgate.Leidinger.net (mailgate.leidinger.net [IPv6:2a00:1828:2000:313::1:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (P-256) client-digest SHA256) (Client CN "mailgate.leidinger.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PClk525gBz3F1L for ; Fri, 10 Feb 2023 07:29:49 +0000 (UTC) (envelope-from Alexander@leidinger.net) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=leidinger.net header.s=outgoing-alex header.b=tHEstQJ+; spf=pass (mx1.freebsd.org: domain of Alexander@leidinger.net designates 2a00:1828:2000:313::1:5 as permitted sender) smtp.mailfrom=Alexander@leidinger.net; dmarc=pass (policy=quarantine) header.from=leidinger.net Received: from outgoing.leidinger.net (p5b165a22.dip0.t-ipconnect.de [91.22.90.34]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256 client-signature ECDSA (P-256) client-digest SHA256) (Client CN "outgoing.leidinger.net", Issuer "R3" (verified OK)) by mailgate.Leidinger.net (Postfix) with ESMTPSA id 69E39B10 for ; Fri, 10 Feb 2023 08:29:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leidinger.net; s=outgoing-alex; t=1676014176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=icEHPnApannPomhicBVxR1tP1McNXZ+xJBjjzJyih5c=; b=tHEstQJ+/WukBqWeBe2+oqH/Kny5H69rC9wJ84dkdfircT4DIHQWygXIAoPPby3d5ZKqXH gidP5mLqCM5wOp4nywhdTAPNnGYVOMCyf1xRHX8uebVJj5BBrM6vZWADU1fE8wFZ/qiNXv KSH9bEdjr3dtA8U2rWOVBQTpDXMzHGyz26BGAMTUeoeB6nL+c2v6oOYtT42+KLaomdCx4G t12KaqAjT6hjQgpnpEuoyiuoSxwMeqDesaFoj4SYPulxQpexTkwD7ghJmE25mTreLsGgiU SqCbOwB9u1VpYZRhKw6Y0qbuE89gLRTjBJyKCVKZDYY6gpKJDhaKD5k3kr4RwQ== Received: from webmail.leidinger.net (localhost [127.0.0.1]) by outgoing.leidinger.net (Postfix) with ESMTP id 89AE54313 for ; Fri, 10 Feb 2023 08:29:33 +0100 (CET) Received: from www (uid 80) (envelope-from Alexander@leidinger.net) id 51ae2 by webmail.leidinger.net (DragonFly Mail Agent v0.13+ on webmail.leidinger.net); Fri, 10 Feb 2023 08:29:33 +0100 Date: Fri, 10 Feb 2023 08:29:33 +0100 Message-ID: <20230210082933.Horde.VHCBwWtyyCtEIbI1ni40V-Z@webmail.leidinger.net> From: Alexander Leidinger To: dev-commits-src-all@freebsd.org Subject: Re: git: 0dfaefa97547 - main - depend-cleanup.sh: Simplify the logic, and clean bootstrap tools. References: <20230209083133.Horde.q3w2RmVjVzPwrvCq2u6yNUU@webmail.leidinger.net> <86ttzvw4qe.fsf@ltc.des.no> In-Reply-To: <86ttzvw4qe.fsf@ltc.des.no> Accept-Language: de,en Content-Type: multipart/signed; boundary="=_oF2r8I1B6sS3ZGcCXe-z8Ti"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 X-Spamd-Result: default: False [-6.08 / 15.00]; SIGNED_PGP(-2.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.98)[-0.981]; DMARC_POLICY_ALLOW(-0.50)[leidinger.net,quarantine]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; R_SPF_ALLOW(-0.20)[+mx]; R_DKIM_ALLOW(-0.20)[leidinger.net:s=outgoing-alex]; MIME_TRACE(0.00)[0:+,1:+,2:~]; DKIM_TRACE(0.00)[leidinger.net:+]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; MID_RHS_MATCH_FROMTLD(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_LAST(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; ASN(0.00)[asn:34240, ipnet:2a00:1828::/32, country:DE] X-Rspamd-Queue-Id: 4PClk525gBz3F1L X-Spamd-Bar: ------ X-ThisMailContainsUnwantedMimeParts: N This message is in MIME format and has been PGP signed. --=_oF2r8I1B6sS3ZGcCXe-z8Ti Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Quoting Dag-Erling Sm=C3=B8rgrav (from Thu, 09 Feb 2023= =20=20 10:46:49=20+0100): > Alexander Leidinger writes: >> You change from "no fork+exec if the file doesn't exist" (due to "if" >> and "[" being shell-builtins) to "always fork+exec". On fast machines >> surely not an issue, on slow ones, it may make a difference (I have an >> old amd64 machine at an ISP which takes days to do a buildworld with >> -j2 due to not much memory, only 2 cores, old HDs, and other stuff >> going on in parallel). > > Have you measured this? Because the whole point of clean_dep() is that No, I haven't measured, for this reason I used "may". > the file it looks for nearly always exists. It's the grep we're not > sure of. So checking if the file exists is nearly always a waste. Thanks for clarifying that. >> While the .depend.* namespace is surely controlled by us, would it >> make sense to change the glob to ".{o,pico}" instead of ".*o" instead >> to prevent unexpected surprises in the future? > > Our sh does not support the {} syntax. Besides, what would it change? > What else would match .*o but not .{o,pico}? My point here is, that making this more specific (we can also list the=20= =20 files=20explicitely), we _maybe_ can prevent foot-shooting in the=20=20 _future_,=20in case there is something else added. I've seen enough=20=20 cases=20where wildcarded removals caused harm after a little change in=20= =20 some=20other place. I have no doubts that you checked that this=20=20 _currently_=20is working fine. Based upon my experience in=20=20 troubleshooting=20issues with "lost files" after an innocent change=20=20 somewhere=20else, I prefer to at least ask about it. Bye, Alexander. --=20 http://www.Leidinger.net=20Alexander@Leidinger.net: PGP 0x8F31830F9F2772BF http://www.FreeBSD.org netchild@FreeBSD.org : PGP 0x8F31830F9F2772BF --=_oF2r8I1B6sS3ZGcCXe-z8Ti Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIzBAABCAAdFiEER9UlYXp1PSd08nWXEg2wmwP42IYFAmPl8lwACgkQEg2wmwP4 2IaVeQ/8DNQrqxCJBx+VwNP2EOXxRy/6lPEJ5Nj6uv1JgSyDm01RiVQwJyadBIG7 VrAKiDcE/R7STDJLHjFQAwKEedxHN6JRdPr9opLN+jb63FTg7HGjby8cK38CuHn/ eLCt3kD6uOUBJFEGK9M1QL6W1zERdCn6NBvCOgfwvQNFjsWdlAbk57EDcahSmfRz yF9jHjTuhGVO2Xv3cyqoq2e1U1QbwH8eBVZ64NUN03WOVD1IymcQFYaqTI69FhHb 06Mfk6IZUKMygj8BqckhqjTHMO4c28w1he7R3UIAcc0WznAgH4Hfmomc9Yb29sR/ AnJLMzI4epLJZSdwZvBOPPzFvaOAbHgoWfWQrKvU/aFVCqlPFVn5o5XK0qQzECPU Zcq3WYYf6YSgoAThCHeKk+QiZNDU2O3YEFpioebjUi20yy9PUKAtpzsZbc26uRTp 7ozUOKkaTAN+crPaVVONT8LtOxDRAyyd6myhOrvFef4vpVUS76hLq59X3a5UW8X/ Yzpu0MQ2tZPmyAizkaNNgAzk2W2rWvejHVxW+N5ig2O6xTuvLgoPVq6JfuxTWQkW +GwOwOrM1i+GYSlivjFw57xSCDP3L/R+EJitRRUP1TtD+93wmoqjrAerj+FUIfyq cNDIZGAow9tS5pucXDzaDijlSk4/TY64LvGWFLcKUxvhNmWvbtI= =Fo8s -----END PGP SIGNATURE----- --=_oF2r8I1B6sS3ZGcCXe-z8Ti--