From owner-freebsd-arm@FreeBSD.ORG Tue Nov 25 19:01:32 2008 Return-Path: Delivered-To: arm@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A78C51065670 for ; Tue, 25 Nov 2008 19:01:32 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from smtp.ht-systems.ru (mr0.ht-systems.ru [78.110.50.55]) by mx1.freebsd.org (Postfix) with ESMTP id 5F09A8FC1B for ; Tue, 25 Nov 2008 19:01:32 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from [85.21.245.235] (helo=orion.SpringDaemons.com) by smtp.ht-systems.ru with esmtpa (Exim 4.62) (envelope-from ) id 1L52hJ-0000K3-Dr; Tue, 25 Nov 2008 21:31:41 +0300 Received: from orion (localhost [127.0.0.1]) by orion.SpringDaemons.com (Postfix) with SMTP id 09955398F3; Tue, 25 Nov 2008 21:24:14 +0300 (MSK) Date: Tue, 25 Nov 2008 21:24:09 +0300 From: Stanislav Sedov To: "M. Warner Losh" Message-Id: <20081125212409.3dab8178.stas@FreeBSD.org> In-Reply-To: <20081125.104452.535842403.imp@bsdimp.com> References: <20081125.104452.535842403.imp@bsdimp.com> Organization: The FreeBSD Project X-XMPP: ssedov@jabber.ru X-Voice: +7 916 849 20 23 X-PGP-Fingerprint: F21E D6CC 5626 9609 6CE2 A385 2BF5 5993 EB26 9581 X-Mailer: carrier-pigeon Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: arm@FreeBSD.org Subject: Re: Code review request: boards on AT91 X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Nov 2008 19:01:32 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Tue, 25 Nov 2008 10:44:52 -0700 (MST) "M. Warner Losh" mentioned: > I'm trying a little experiment. I'm moving the board support for the > different sets of boards we support to their own file. This is the > first step in moving to supporting multiple boards more easily. > There's a number of gross hacks to make this work now in at91 land, > and I'd like to clean them up. The mv port is much cleaner, but we > still likely need some way to identify boards and get the right board > support code called. In Linux land, all ARM boot loaders are expected > to pass in a machine type, which is used to do the multiplexing. > Something similar in FreeBSD would be useful (and not just for ARM). > > Eventually, I'd like to see more common code between the different arm > variants. This will ease porting efforts as well as make the code > more robust. I think we could pass the board type via a special kenv variable for now. I think it will work fine and applicable to all supported architectures. We could probably reuse board type constants that Linux kernel uses. > > If anybody wants me to write up where I'm going with this, or answer > any question, please feel free to ask. Also, comments would be nice. > > Warner > The code looks OK to me. I have only one question: why you have added a commented out AT91_BOARD_KB920X option to the default kernel config? Is it just a leftover? - -- Stanislav Sedov ST4096-RIPE -----BEGIN PGP SIGNATURE----- iEYEARECAAYFAkksQs0ACgkQK/VZk+smlYFntwCfbHv6JJmTjzI6GL5Ra1k4nA2a nGAAn06uoskVCyZ2E5eFkTtQQ7eXnmz0 =xuFv -----END PGP SIGNATURE-----