From owner-svn-src-all@freebsd.org Mon Apr 20 16:40:01 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C6BE02C73AC; Mon, 20 Apr 2020 16:40:01 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 495XVT4vXfz4drC; Mon, 20 Apr 2020 16:40:01 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: by mail-qt1-x834.google.com with SMTP id s30so9056645qth.2; Mon, 20 Apr 2020 09:40:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=n+EGHHpa8f0nioE+GU6/REPuXKlW5Ns3PTFi9MThXj8=; b=XxZD+vLqSHWGRImzjOV2nB2pPMbnboJnJpnZKMXrt1zo72jjECjEEjZUZUpIiu44Cr LwBLWeVZqDhLTA0VTRtz6TSqtFjhx/6fTgxlaoa8O+i2OqHcouRvOqRNVE0zjVmGnc6H 6KinocPp+tByvX07dsb4si7JR25qHGTpKYImo+CmuD2mNd6bvZEqefdZ+9kwuiYjckMI UcayfyYeIZGHa3VjhXDmMQESqB38R08irxEoo3nAicQJqlAY+J+J0CnJtT2g1pO1Q7RW doUrGeMYFv2RkMpmtt9lPkydicv8r/+P9m7PZtm/Sd5FlkUSfuWHGKL+RELGB8iimu8c o6Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=n+EGHHpa8f0nioE+GU6/REPuXKlW5Ns3PTFi9MThXj8=; b=XbmctXUCN0KsP++b+H/sHFudrEESAapE9zDVlKY3HONt2cCJnex1cw0hrP0dMvjYTh P3xiJGyuxihDEZcPFkAmf4yf8tPBi0AbgVmsc78k+mm1Lunlvv1cbuKjX40aw6ubydvN mXhbwc19nbU792MyQBH2gwqzS435EQWRSCLMrqhmqKv4LrHZumScZW3z6tztzc3sELcq DLHsFMaSNIO6WUSK661tNTuvD6i+f7RIKpUgDWFJLyFaVBglHDpCk1QpmS9x1kasOpct 6UexiO3CnWEivm5fG2VXVX5ZOy5E5IPeEoC7KiSLAPF3OyvL2nuox1WahyKkRltOlkaO pq4w== X-Gm-Message-State: AGi0PuZQcUmSLyaOUwTLnrJllQEY39XzgrHQN0Q7e0uGVDYeGBfVDjmk Sr77g1CAId9YT9lL+bHHTV/nKGi9NfM= X-Google-Smtp-Source: APiQypJvJg/m5Fbt04P8Q5MkehMFPOAVNhSdc1yO/BvcSSlHhgRiuCqUr03eXqgNcgHq12AakNuM8Q== X-Received: by 2002:ac8:1084:: with SMTP id a4mr16932671qtj.156.1587400800193; Mon, 20 Apr 2020 09:40:00 -0700 (PDT) Received: from titan.knownspace (173-19-125-130.client.mchsi.com. [173.19.125.130]) by smtp.gmail.com with ESMTPSA id u24sm18651qkk.84.2020.04.20.09.39.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2020 09:39:59 -0700 (PDT) Date: Mon, 20 Apr 2020 11:39:57 -0500 From: Justin Hibbits To: Niclas Zeising Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r360126 - head/sys/dev/evdev Message-ID: <20200420113957.50d41308@titan.knownspace> In-Reply-To: <202004201617.03KGHHj7074077@repo.freebsd.org> References: <202004201617.03KGHHj7074077@repo.freebsd.org> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; powerpc64-portbld-freebsd13.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 495XVT4vXfz4drC X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2020 16:40:01 -0000 On Mon, 20 Apr 2020 16:17:17 +0000 (UTC) Niclas Zeising wrote: > Author: zeising (doc,ports committer) > Date: Mon Apr 20 16:17:16 2020 > New Revision: 360126 > URL: https://svnweb.freebsd.org/changeset/base/360126 > > Log: > Change kern.evdev.rcpt_mask to 12 by default > > Change kern.evdev.rcpt_mask from 3 to 12 by default. This makes us > much more evdev-friendly, and will prevent everyone using xorg and > wayland with evdev devices (the default) from needing to change this > locally. > powerpc32 still uses the old value for the keyboard part, becaues > the adb keyboard driver used there is not evdev compatible. > > Reviewed by: wulf > Approved by: wulf > MFC after: 2 weeks > X-MFC-Note: 12 only > Relnotes: yes > Differential Revision: https://reviews.freebsd.org/D24370 > > Modified: > head/sys/dev/evdev/evdev.c > > Modified: head/sys/dev/evdev/evdev.c > ============================================================================== > --- head/sys/dev/evdev/evdev.c Mon Apr 20 16:14:44 2020 > (r360125) +++ head/sys/dev/evdev/evdev.c Mon Apr 20 16:17:16 > 2020 (r360126) @@ -66,7 +66,12 @@ enum evdev_sparse_result > > MALLOC_DEFINE(M_EVDEV, "evdev", "evdev memory"); > > -int evdev_rcpt_mask = EVDEV_RCPT_SYSMOUSE | EVDEV_RCPT_KBDMUX; > +/* adb keyboard driver used on powerpc does not support evdev yet */ > +#ifdef __powerpc__ This affects *all* powerpc, not just powerpc32. For just powerpc32, you should have: #if defined(__powerpc__) && !defined(__powerpc64__) But I'm curious, why not attach to sysmouse(4) and kbdmux(4)? What breakage does that cause? I could maybe see not attaching to sysmouse(4) by default, if the protocol isn't expressive enough, but kbdmux(4) should be sufficient. - Justin