Date: Wed, 20 May 2020 19:45:05 +0200 From: Martin Neubauer <m.ne@gmx.net> To: freebsd-ports@freebsd.org Subject: Re: Port OPTIONS advice Message-ID: <8dc831a5-3143-a35f-3ba4-8007b8b5bc8a@gmx.net> In-Reply-To: <CAHNAqm8qkMC1ATdL5Yh95aX5h-0YU86G2O-otWqaWrv6tF4yoQ@mail.gmail.com> References: <CAHNAqm8qkMC1ATdL5Yh95aX5h-0YU86G2O-otWqaWrv6tF4yoQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--EmoaSflwrJRPbuupzkh6zPf8tXoKjFZx8
Content-Type: multipart/mixed; boundary="EASnoWQ2Gk8ZuLcDUTr7AmzBg8hOC3gKj"
--EASnoWQ2Gk8ZuLcDUTr7AmzBg8hOC3gKj
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
How about something like:
----------------------------
OPTIONS_DEFINE_amd64=3D JIT
OPTIONS_DEFINE_i386=3D JIT
JIT_CONFIGURE_ENABLE=3D jit
----------------------------
On 20/05/2020 19:25, SirDice wrote:
> Hi,
>=20
> Some time ago I took over maintainership of fs-uae. Port itself is doin=
g
> great but I wanted to enable the JIT option to experiment with (it buil=
ds
> but crashes the application; that's an entirely different issue though)=
=2E To
> enable it I had added this:
>=20
> OPTIONS_DEFINE_i386=3D JIT
> OPTIONS_DEFINE_amd64=3D JIT
>=20
> Because the option is only available for i386/amd64 I wanted the port
> option to only show up on x86. Unfortunately the brain-dead ./configure=
> script simply assumes --with-jit on all architectures. As these OPTIONS=
> were only available on x86, any other ARCH never passes --without-jit t=
o
> ./configure and thus it fails to build.
>=20
> The quick solution was to use OPTIONS_DEFINE=3D JIT and make the port o=
ption
> available everywhere. However, if you try to enable it you will run in=
to
> build failures on Powerpc or ARM for example.
>=20
> I could do this:
> -----------------------------
> OPTIONS_DEFINE_i386=3D JIT
> OPTIONS_DEFINE_amd64=3D JIT
>=20
> .include <bsd.port.pre.mk>
>=20
> # JIT is not supported on non-x86
> .if ${ARCH} !=3D amd64 && ${ARCH} !=3D i386
> CONFIGURE_ARGS+=3D --without-jit
> .endif
> ----------------------------
>=20
> Or do something like this:
> ----------------------------
> OPTIONS_DEFINE=3D JIT
>=20
> .include <bsd.port.pre.mk>
>=20
> .if ${PORT_OPTIONS:MJIT}
> ONLY_FOR_ARCHS=3D i386 amd64
> .endif
>=20
> ----------------------------
>=20
> The JIT OPTION is off by default in all cases. But I would like to onl=
y
> have it appear on supported architectures or have some sort of sanity c=
heck
> so it doesn't get enabled on unsupported architectures. As I need to up=
date
> the port (new version came out) I would like to fix this OPTION issue t=
oo.
>=20
> What's a good way to deal with this sort of architecture dependent opti=
on?
>=20
> Thanks for your time,
>=20
> Remko C.
> _______________________________________________
> freebsd-ports@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-ports
> To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org=
"
>=20
--=20
Any environmental problem can be solved by a good Ice Age.
--EASnoWQ2Gk8ZuLcDUTr7AmzBg8hOC3gKj--
--EmoaSflwrJRPbuupzkh6zPf8tXoKjFZx8
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEMHVrsqKu60F5jvxaoBLYqhRr9C0FAl7FbLAACgkQoBLYqhRr
9C3fWA//fKsRmmgTgWpfuZN24DC+XhIhLurbszA+hfkGE20iF5HejIIfAMd+CASN
T8prebHVNJvHdf2I6rxD/xJ4VQpldxsXmJOutah39hSlG5Vu5bJB5NuEJIFdiU5T
/2yE2jM/OI0yi6sjds9ssZouNlB7rDkQnG8feacarW5HFbo3symcJoldDlq9H5Ji
LX2ipS3Wy5VoOQQnwTjxyvCJrdheNUNq16FMXUnQq4Rav65SE8GuEx/69OSoDQdT
Fk9DqiFVu4gijpzq5+jx/EFjaqB4rkFpQLEHIs3WU+9oU5Ni5zzXSy7Qxg0UDGpM
hsSBFdI3AOqZMOt404EdimzFMFsK4tNRLUK65NHmtmJbYqADhmaHFGEtYSfRzJsM
7t43J6Q4eOpZN9UiiphqPQkXKKRhurOdn8ZkSu2NOVM/JWQ2GEaOEdzpkzuyAX3X
Mj7S5ioMTiIBo4OMDRkIT6U+F5jYG/1f/b/PtJkX2Y/Vc6pwLMXWv831617UIUPI
n7QrGbk5mLDHBghRYP7s3DLb3ZcrShvOE4ijrr1+804BRCl2GVFS7jjv/wD1oF8K
nZ9dyqvUyadm2lbYcdCx8UYQk6KLDXOSokkqyMwdVM4OVh9AqeH/ig3cYSdTgGqn
3IgOEI+FWG5Qzb0vwniq97VPx9f5SW+gRMCm6PyNDsERLERhbVw=
=c9Sq
-----END PGP SIGNATURE-----
--EmoaSflwrJRPbuupzkh6zPf8tXoKjFZx8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8dc831a5-3143-a35f-3ba4-8007b8b5bc8a>