From nobody Tue Aug 4 18:41:48 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hF2Sr5hM5z6nDDG for ; Tue, 04 Aug 2026 18:41:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hF2Sr4Tndz4B6H for ; Tue, 04 Aug 2026 18:41:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785868908; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VoP2/TUC69TKpmASZs5pNimt4uxA7J4zH8n0nHztpFk=; b=RAByg9kiFCIPM4IgNFEYYG5IQtPo7yrkIpymRuLhDSPfStUfKNVQNul9GBrNcFpDSXUc5j VLuPRmnBr2po6v4Eb57a77/BVMdzu7ZHqaZGZUlUgju/QnbDsaQVTZW2xTC/pnRcYnTQGW 0Ell8c1eFw8pxyfiTjHqSRRr7TvQv0tAt9huRyw8ag18u2HrB+nD2hftqzas15YjkEs3tW iYKhFNhMFKrQ72qtCwoyml8VJW7nJeic7OK8s/SJAtxoJKoN3qktRJBKbMUUMkh4vYaSwP 7dVFAM0MUkVOPRLmHW9tOOlRpTrYSHqa25+EGKHD+gf94bP5+gS0DsHTKVnbBw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785868908; a=rsa-sha256; cv=none; b=Q3AvzbMHmlasWBLNagcpKDAVkGKOKCu9iv5gr1EDuLDi4dgbwb27tXB6/upYAk8D0UfZLU ZFaUT75kID27SLBGAub3i8krsnfez1qyqOtCKu9lU8Q1/+3oBpiswr+Hn4DfdHvcY6vaLj bxEUtm/nkullNw34vMPqqETSQzb1V6KVgAySQM8Z/XvDu/JJG6ethmwToCHOq05O3bjJ5U D/E5StMKU1nguj8AT2KmqX0N5vu7YKYli78N13uaoowVLZcbQIh9H6dReQB3z6YC/Kq88a yzfGkc97xFgNK/NYsSau0utET3CUmSov9tBom6Do4clW9/hQ9YJpT4OXbByk/g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785868908; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VoP2/TUC69TKpmASZs5pNimt4uxA7J4zH8n0nHztpFk=; b=jaS5ojvna6gg0NBT4xMzZoWGaA19jnqi8JCow1q8eU2A5+h2Unvck0qjrdl5bBa6Dxcdie 6tUbQrr6VmwSN1ilExeuvGjOOpLWbyyDzBvYYwRjXbicVO81dwVUaRzchYDZqOuNBY9jXC nFzCUsqhkNU3rzw+ZO+SXntdRDLrFYZQFl6f59eMivPxRmD93uojOvpVtePx7LNjacA9vh +YkYMMv+GTyXOIx7KzK4JFchVl/17+pLbuCbUORZBlyNL6l1/x3zd8D9Vys0+5wShAy0Ip 99llzdy0USE8fQ+fvM+5ot1I4MPNRPj+kdraEiair74l9TnDQVXWVlv43tNTYg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hF2Sr2ymSzyfc for ; Tue, 04 Aug 2026 18:41:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3321f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 04 Aug 2026 18:41:48 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: ac134a488a6e - stable/14 - ixl: enforce the assigned VF MAC address List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: ac134a488a6e50d47df3ec5f45604a8b30ca4021 Auto-Submitted: auto-generated Date: Tue, 04 Aug 2026 18:41:48 +0000 Message-Id: <6a72326c.3321f.7f6e0b71@gitrepo.freebsd.org> The branch stable/14 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=ac134a488a6e50d47df3ec5f45604a8b30ca4021 commit ac134a488a6e50d47df3ec5f45604a8b30ca4021 Author: Kevin Bowling AuthorDate: 2026-08-01 02:38:54 +0000 Commit: Kevin Bowling CommitDate: 2026-08-04 18:41:36 +0000 ixl: enforce the assigned VF MAC address When allow-set-mac is disabled, the MAC filter validation condition rejects the assigned VF unicast address while allowing any different unicast address. The equality test was accidentally inverted when this code moved to the boolean address helper. Accept multicast and the assigned unicast address, and reject other unicast addresses as intended. Fixes: 7d4dceec1030 ("ixl(4): Fix VLAN HW filtering") (cherry picked from commit d2309d9d6dc6d5a9141314652d6c96ab46a9a62c) --- sys/dev/ixl/ixl_pf_iov.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/dev/ixl/ixl_pf_iov.c b/sys/dev/ixl/ixl_pf_iov.c index ca2759557066..1e475e4767cc 100644 --- a/sys/dev/ixl/ixl_pf_iov.c +++ b/sys/dev/ixl/ixl_pf_iov.c @@ -1022,7 +1022,7 @@ ixl_vf_mac_valid(struct ixl_vf *vf, const uint8_t *addr) * is not its assigned MAC. */ if (!(vf->vf_flags & VF_FLAG_SET_MAC_CAP) && - !(ETHER_IS_MULTICAST(addr) || !ixl_ether_is_equal(addr, vf->mac))) + !(ETHER_IS_MULTICAST(addr) || ixl_ether_is_equal(addr, vf->mac))) return (EPERM); return (0); @@ -1824,4 +1824,3 @@ out: return (error); } -