From owner-cvs-src@FreeBSD.ORG  Thu Oct  9 12:45:47 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 931)
	id EBE1A16A4BF; Thu,  9 Oct 2003 12:45:47 -0700 (PDT)
Date: Thu, 9 Oct 2003 14:45:47 -0500
From: Juli Mallett <jmallett@FreeBSD.org>
To: Bruce Evans <bde@zeta.org.au>
Message-ID: <20031009144547.A77413@FreeBSD.org>
References: <200310090945.h999jKns055269@repoman.freebsd.org>
	<20031009121355.GD94235@madman.celabo.org>
	<20031009222521.W9649@gamplex.bde.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <20031009222521.W9649@gamplex.bde.org>;
	from bde@zeta.org.au on Thu, Oct 09, 2003 at 10:37:27PM +1000
X-Title: Code Maven
X-Towel: Yes
X-Negacore: Yes
X-Authentication-Warning: localhost: juli pwned teh intarweb
cc: "Jacques A. Vidrine" <nectar@freebsd.org>
cc: Hiten Pandya <hmp@freebsd.org>
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
cc: cvs-src@freebsd.org
Subject: Re: cvs commit: src/lib/libufs bread.3 cgread.3 getino.3 libufs.3
	sbread.3 ufs_disk_close.3
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Oct 2003 19:45:48 -0000

* Bruce Evans <bde@zeta.org.au> [ Date: 2003-10-09 ]
	[ w.r.t. Re: cvs commit: src/lib/libufs bread.3 cgread.3 getino.3 libufs.3 sbread.3 ufs_disk_close.3 ]
> On Thu, 9 Oct 2003, Jacques A. Vidrine wrote:
> 
> > On Thu, Oct 09, 2003 at 02:45:20AM -0700, Hiten Pandya wrote:
> > > hmp         2003/10/09 02:45:20 PDT
> > >
> > >   FreeBSD src repository (doc committer)
> > >
> > >   Modified files:
> > >     lib/libufs           bread.3 cgread.3 getino.3 libufs.3
> > >                          sbread.3 ufs_disk_close.3
> > >   Log:
> > >   Remove unneccessary include of sys/types.h in the SYNOPSIS
> > >   header.
> > >
> > >   Sys/param.h includes sys/types.h internally unless LOCORE is
> > >   defined.
> 
> Including both is also a style bug.
> 
> > I think you removed the wrong header.  Is <sys/param.h> required in
> > each of these cases?  If not, then I believe the synopsis should refer
> > only to <sys/types.h>:
> 
> <sys/param.h> is a prerequisite for <sys/mount.h> and some of the other
> headers.  <sys/mount.h> is a prerequisite for <ufs/ufs/ufsmount.h>,
> but the mount headers are not needed for much if anything in these
> interfaces.  <sys/param.h> is only needed to define MAXBSIZE otherwise.
> 
> getino.3 might be more useful if it were installed.

It would be more useful if the code were committed.  I think I never
did that because of some alignment issues on various platforms.  If
someone wants a copy of what my WIP look{s,ed} like, I can point to it
on request.

Thanx,
juli.
-- 
juli mallett. email: jmallett@freebsd.org; efnet: juli; aim: bsdflata;
i have lost my way home early - i don't care cause i won't stay there.