From owner-freebsd-www@FreeBSD.ORG Thu Sep 1 20:07:32 2005 Return-Path: X-Original-To: www@freebsd.org Delivered-To: freebsd-www@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EA8E716A41F for ; Thu, 1 Sep 2005 20:07:32 +0000 (GMT) (envelope-from keramida@freebsd.org) Received: from aiolos.otenet.gr (aiolos.otenet.gr [195.170.0.93]) by mx1.FreeBSD.org (Postfix) with ESMTP id C24C743D53 for ; Thu, 1 Sep 2005 20:07:31 +0000 (GMT) (envelope-from keramida@freebsd.org) Received: from orion.daedalusnetworks.priv (aris.bedc.ondsl.gr [62.103.39.226]) by aiolos.otenet.gr (8.13.4/8.13.4/Debian-1) with SMTP id j81K7Tu4030266; Thu, 1 Sep 2005 23:07:29 +0300 Received: from orion.daedalusnetworks.priv (orion [127.0.0.1]) by orion.daedalusnetworks.priv (8.13.4/8.13.4) with ESMTP id j81K7SaM040502; Thu, 1 Sep 2005 23:07:29 +0300 (EEST) (envelope-from keramida@freebsd.org) Received: (from keramida@localhost) by orion.daedalusnetworks.priv (8.13.4/8.13.4/Submit) id j81K7SRc040501; Thu, 1 Sep 2005 23:07:28 +0300 (EEST) (envelope-from keramida@freebsd.org) X-Authentication-Warning: orion.daedalusnetworks.priv: keramida set sender to keramida@freebsd.org using -f Date: Thu, 1 Sep 2005 23:07:28 +0300 From: Giorgos Keramidas To: Daniel Gerzo Message-ID: <20050901200727.GA40448@orion.daedalusnetworks.priv> References: <1029392505.20050901194124@rulez.sk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1029392505.20050901194124@rulez.sk> Cc: www@freebsd.org Subject: Re: query-pr-summary.cgi rework X-BeenThere: freebsd-www@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD Project Webmasters List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Sep 2005 20:07:33 -0000 On 2005-09-01 19:41, Daniel Gerzo wrote: > Hello www, > > I would like to announce my work to you and get some feedback. If > you feel that the patch is okay and doesn't need any more changes, > I would like to send PR and get it commited :-) > > Changes to the query-pr-summary.cgi script include: > > o) rewritten code so it's more readable now, replaced some " with '. > o) make the html output html valid. > o) the minor feature I've added is that the PRs in the html output > are now splitted according to the each PR's state and each state > has it's own color, so it's easier now to determinate the PR's > state on the web page. This has been done by adding a few css > classes, so if colors aren't meeting our needs, it is pretty > easy to modify them. > > This work was already tested by remko@ and it seems to work. The > affects of my work are visible at for example: > > http://people.freebsd.org/~remko/danger-test/query-pr-summary2.cgi?category=conf This looks nice. I like the use of the existing stylesheet for coloring. If Remko wants to commit it, there's no objection from me.