From owner-freebsd-rc@FreeBSD.ORG Sat Oct 27 17:28:08 2012 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5A78DF6C; Sat, 27 Oct 2012 17:28:08 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id A85C78FC14; Sat, 27 Oct 2012 17:28:07 +0000 (UTC) Received: by mail-bk0-f54.google.com with SMTP id jf20so1622470bkc.13 for ; Sat, 27 Oct 2012 10:28:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=HyaICV0p3j1YRFIw6HpQzKWZGIElaYFCu8WYozp0i3w=; b=zyhUX1Xd78TcNU7hK+qFxKoFCX8nU76bQlYzYl2C5mD677QlRVztJ4X1jBLB4Sy0Iu kVvYpibZ/sGSmLBd/OByA3nkfRIhI07d0vBPRrZJMFIjUBTsHsd8+NdGjXP1Yj/AU4p/ mFqGO2TBJ0ysXbvg0mEbp+k1OYwhHs+9tLt3csmSRCiTZgv9UURhbgNGKgcCXUEkmIWD 6NgSjdmFDdIy4h6MrUM2xNPAT+dRZr/YYFOtrgMfPOkC/kP4xKjiX4cJaX7buTpehCjm 8PWQH87j5PuR82p+a02nfP1Eu+yDiK6814ECVdkGylxKP6qUnhq4Xeowt77ifvBoh3tM RJeg== Received: by 10.205.137.7 with SMTP id im7mr7866214bkc.25.1351358886583; Sat, 27 Oct 2012 10:28:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.50.197 with HTTP; Sat, 27 Oct 2012 10:27:35 -0700 (PDT) In-Reply-To: <20121028.021752.529031225588915529.hrs@allbsd.org> References: <20121028.021752.529031225588915529.hrs@allbsd.org> From: Chris Rees Date: Sat, 27 Oct 2012 18:27:35 +0100 Message-ID: Subject: Re: Spaces in ${name}_chroot To: Hiroki Sato Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-rc@freebsd.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Oct 2012 17:28:08 -0000 On 27 October 2012 18:17, Hiroki Sato wrote: > Chris Rees wrote > in : > > ut> Hi all, > ut> > ut> A guy in IRC pointed out to me that rc.subr will not work correctly if > ut> a chroot has spaces in it. > ut> > ut> Although this is unlikely, would it hurt to include it? Lacking a src > ut> bit someone may need to put their name to it, but I'm happy to commit > ut> & handle MFCs. > ut> > ut> Chris > ut> > ut> [1] http://www.bayofrum.net/~crees/patches/rc-subr-support-chroot-spaces.diff > > I think this patch is correct. Please go ahead. Should I give it 1 month MFC, or leave it in head? Thanks very much for replying! Chris