From owner-freebsd-stable@FreeBSD.ORG Thu Mar 19 19:15:53 2009 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3CAE71065723 for ; Thu, 19 Mar 2009 19:15:53 +0000 (UTC) (envelope-from tim@chase2k.com) Received: from smtp.onlight.com (mx1.onlight.com [69.129.177.182]) by mx1.freebsd.org (Postfix) with ESMTP id EEC438FC08 for ; Thu, 19 Mar 2009 19:15:52 +0000 (UTC) (envelope-from tim@chase2k.com) Received: from localhost (livingston [127.0.0.1]) by clean.onlight.com (Postfix) with ESMTP id 2EB78830272D; Thu, 19 Mar 2009 14:08:23 -0500 (CDT) X-Virus-Scanned: amavisd-new at onlight.com Received: from smtp.onlight.com ([127.0.0.1]) by localhost (filter.onlight.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 6vC9MZl3UPoy; Thu, 19 Mar 2009 14:08:22 -0500 (CDT) Received: from chase2k.com.vpn.onlight.com (chase2k.com.vpn.onlight.com [10.8.0.33]) by smtp.onlight.com (Postfix) with ESMTPA id D43A583218BC; Thu, 19 Mar 2009 14:08:21 -0500 (CDT) Date: Thu, 19 Mar 2009 14:08:18 -0500 (CDT) From: Tim Chase Sender: tim@cardinal.onlight.com To: John Baldwin In-Reply-To: <200903191246.05641.jhb@freebsd.org> Message-ID: References: <200903191001.44491.jhb@freebsd.org> <20090319160251.GJ7716@deviant.kiev.zoral.com.ua> <200903191246.05641.jhb@freebsd.org> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Kostik Belousov , freebsd-stable@freebsd.org Subject: Re: in recent 7-STABLE: VOP_WRITE...is not exclusive locked but should be X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Mar 2009 19:15:54 -0000 Hello, Regarding: >>>> As to the deadlock that started this exercise, if the machine follows > its >>>> recent pattern, that should happen within the next 2-4 hours. FWIW, it did _not_ deadlock this morning and there haven't been any more of the "is exclusive locked" messages have come out, either. John Baldwin asked: > Hmm, it depends on where the check is I guess (before or after zfs_write()). > Tim, can you do 'l *VOP_WRITE_APV+0x155' on your kernel from gdb? (kgdb) l *VOP_WRITE_APV+0x155 0xffffffff8048f4b5 is in VOP_WRITE_APV (vnode_if.c:704). 699 ASSERT_VOP_ELOCKED(a->a_vp, "VOP_WRITE"); 700 } else { 701 ASSERT_VI_UNLOCKED(a->a_vp, "VOP_WRITE"); 702 ASSERT_VOP_ELOCKED(a->a_vp, "VOP_WRITE"); 703 } 704 VOP_WRITE_POST(a, rc); 705 return (rc); 706 } 707 708 struct vnodeop_desc vop_write_desc = { (kgdb) Line 704 would appear to be after the ZFS write which I guess means ZFS is doing something it shouldn't be? - Tim