From owner-freebsd-current@FreeBSD.ORG Wed Feb 27 18:43:06 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 5B4FEF34 for ; Wed, 27 Feb 2013 18:43:06 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id A30EF75D for ; Wed, 27 Feb 2013 18:43:05 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.6/8.14.6) with ESMTP id r1RIh1w1058194; Wed, 27 Feb 2013 20:43:01 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.0 kib.kiev.ua r1RIh1w1058194 Received: (from kostik@localhost) by tom.home (8.14.6/8.14.6/Submit) id r1RIh1kt058193; Wed, 27 Feb 2013 20:43:01 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 27 Feb 2013 20:43:01 +0200 From: Konstantin Belousov To: Sergey Kandaurov Subject: Re: [patch] Proposal: move getmntopts(3) into libutil Message-ID: <20130227184301.GB2454@kib.kiev.ua> References: <20130226122039.GN2454@kib.kiev.ua> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Fh+fyCUbzktHKe74" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: FreeBSD Current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2013 18:43:06 -0000 --Fh+fyCUbzktHKe74 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 27, 2013 at 07:08:35PM +0300, Sergey Kandaurov wrote: > I have put it on freefall for convenience. > http://people.freebsd.org/~pluknet/patches/getmntopts.2.patch Should the synopsis for getmntopts(3) use #include , instead of '"', as well as the example ? For the mntopts.h itself, I suggest to add an include guard, it is required for system header. I would also take an opportunity and wrapped long lines in mntopts.h in the same change. --Fh+fyCUbzktHKe74 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJRLlO0AAoJEJDCuSvBvK1Bf9sP/RGV0Gj+nv0YDxiiWXCCjp7C f62MfSL+yW7VRvsPUe8W3tXmUkqyn3ln+ESLsylely+e+QupIaprozYsJ6mHjcGC M0/v+DQq7HbI6pzRiGc2v1US+qw3j/bo9dE5qMnd3ij2Ze50NtPq0HIuKJ0t6+9B S2zYDJYz8SyOIGBskwF33rbWU18TNn9FjNfRTuNr2py2b48zMED+3R1mTelbuNxg /jCALjgOBqhrpB+vkMCv4d0JqNoYwGNL3FA0WWxpIkMW2KL/q3/rkJhMdEH4nJjE zr8A/R/kGYNxV4YUJj2Fykjs7fyItliZuL4gT1MnoZq/EfUhVXNwotP16eTazAeg m9IBzMoRrXibTFkj+1kij1AQRKcS1jd/5dAE7sBswyxIAv7yigkmV8aG0DMj4vId /nCHUDbHbOBd4xe6UzS60xtgea6D4PqV5nW1lXJ87qN9EzPA5Nua/2LQ+T6GvYMc 0BDB7EWU3lMHp5QOQ36itlsdqr0csO0uKz62VM8OHTQjZ4D3l/L8ApfYq/G+vpem 9/ei6eyKmD1XLEIoBXqMCC9XgdlX/jGUes2HZs739was3cXUpYeAwdrvxE34PQuT gNYD4iN90dTxiHuvTIeOx8KsxXIjjqKT6yYj2Dyr/dXo/p0G9baQ96hESfXtnWGj d6sFl9S0IQz8xuph8tzF =5P87 -----END PGP SIGNATURE----- --Fh+fyCUbzktHKe74--