From owner-svn-src-head@freebsd.org Thu Jun 16 17:43:56 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 42087A76FAD; Thu, 16 Jun 2016 17:43:56 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x22a.google.com (mail-pf0-x22a.google.com [IPv6:2607:f8b0:400e:c00::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 133ED1E2C; Thu, 16 Jun 2016 17:43:56 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x22a.google.com with SMTP id c2so22057426pfa.2; Thu, 16 Jun 2016 10:43:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=hhWWEch+djOLxYhC5o11VGZndJ2xBCjEKOOG6pWBYOM=; b=c3y1kYwVEe5n9/1RqdP6hY2uz1+irGRzWjBHAa8DaseMsUWw8YJlrhNrp0hdWycLlf CjQ2y5/jAbaH8fGosPinjjcY6C3hlOqHAQZtkiPwRhcB1agYCUmJWp/Iy0gfqAHcfQIU Ef/sB4LnEl9lhEE1Pdh29/aZWe9ujO1Z+fPyXo3ZX+i9feahLnm2gUOxx8D5u+VaEmDc 2DA9RINAvVPZ0PM9LeS9wEBbWLPAQmdwZpe/AFpwMp1XkSYg0ey4/1HiCMLge0rkXG0d dGHo04gxvJtvrQHgZgXuidAKwKq385FNPs2twWfL7rCESMmxfDaWJ32mFlhftIXnYDNM qEjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=hhWWEch+djOLxYhC5o11VGZndJ2xBCjEKOOG6pWBYOM=; b=bGgMwkpneQOi+n0LgIHmJS/2DbTjFxbvpckhLOwyELRFCUEfLXoHulE/InVEjdfWDH tVvNAi/ETNtmVO2ZRa7ZbkPYGV250iN+qMKepO0fV52vLz3vcFMXqp/q4LchoGo1qWk6 //f/2zD8JJ1NymsmH4LcXaFJ84/8Hfnb+O8kqeqvYkWmopsWWCpJ6SUrXlg051hAG6tA 2UHD9dycaI1gkbyqBQSa04P5wPBrpuwj+ZeVsdRvFXP6DRKSGxqdqirdIhnrh3zUInT0 8yyLPz4o7UQiKlTh0NjyR49gGjyUMk2NwZH4C0FGMZwvb77CMqV/Y5Ol/fJ0IyyrPCZs U53Q== X-Gm-Message-State: ALyK8tKjYP13EYEgA64o6IeyZXrl9qoizTLnJrCjvYUVM3oFQb1EQcMTiToHjmpAVW1ugg== X-Received: by 10.98.74.92 with SMTP id x89mr6549377pfa.79.1466099035228; Thu, 16 Jun 2016 10:43:55 -0700 (PDT) Received: from [29.120.49.71] ([172.58.40.150]) by smtp.gmail.com with ESMTPSA id h77sm30008469pfj.86.2016.06.16.10.43.54 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 16 Jun 2016 10:43:54 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r301959 - head/sys/kern From: Ngie Cooper X-Mailer: iPhone Mail (13F69) In-Reply-To: Date: Thu, 16 Jun 2016 10:43:53 -0700 Cc: Konstantin Belousov , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201606161158.u5GBwkd1042632@repo.freebsd.org> To: cem@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jun 2016 17:43:56 -0000 > On Jun 16, 2016, at 10:17, Conrad Meyer wrote: >=20 >> On Thu, Jun 16, 2016 at 4:58 AM, Konstantin Belousov wr= ote: >> --- head/sys/kern/kern_thread.c Thu Jun 16 11:55:24 2016 (r301958)= >> +++ head/sys/kern/kern_thread.c Thu Jun 16 11:58:46 2016 (r301959)= >> @@ -669,11 +669,6 @@ weed_inhib(int mode, struct thread *td2, >> wakeup_swapper |=3D sleepq_abort(td2, EINTR); >> break; >> case SINGLE_BOUNDARY: >> - if (TD_IS_SUSPENDED(td2) && (td2->td_flags & TDF_BOUNDARY= ) =3D=3D 0) >> - wakeup_swapper |=3D thread_unsuspend_one(td2, p, f= alse); >> - if (TD_ON_SLEEPQ(td2) && (td2->td_flags & TDF_SINTR) !=3D= 0) >> - wakeup_swapper |=3D sleepq_abort(td2, ERESTART); >> - break; >=20 > style(9) nit: /* FALLTHROUGH */ >=20 Also, coverity will complain about the missing break unless that's there... > Best, > Conrad >=20 >> case SINGLE_NO_EXIT: >> if (TD_IS_SUSPENDED(td2) && (td2->td_flags & TDF_BOUNDARY)= =3D=3D 0) >> wakeup_swapper |=3D thread_unsuspend_one(td2, p, f= alse); >=20