From owner-freebsd-bugs@FreeBSD.ORG Tue Sep 30 04:10:22 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 38E4816A4B3 for ; Tue, 30 Sep 2003 04:10:22 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 905C64401F for ; Tue, 30 Sep 2003 04:10:20 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h8UBAKFY061760 for ; Tue, 30 Sep 2003 04:10:20 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h8UBAKGQ061754; Tue, 30 Sep 2003 04:10:20 -0700 (PDT) (envelope-from gnats) Resent-Date: Tue, 30 Sep 2003 04:10:20 -0700 (PDT) Resent-Message-Id: <200309301110.h8UBAKGQ061754@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Andre Albsmeier Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2E71716A4B3 for ; Tue, 30 Sep 2003 04:02:55 -0700 (PDT) Received: from david.siemens.de (david.siemens.de [192.35.17.14]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3C21443F3F for ; Tue, 30 Sep 2003 04:02:51 -0700 (PDT) (envelope-from andre.albsmeier@siemens.com) Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by david.siemens.de (8.11.7/8.11.7) with ESMTP id h8UB2nR02314 for ; Tue, 30 Sep 2003 13:02:49 +0200 (MEST) Received: from mars.cert.siemens.de (ust.mchp.siemens.de [139.23.201.17]) by mail3.siemens.de (8.11.7/8.11.7) with ESMTP id h8UB2nn18505 for ; Tue, 30 Sep 2003 13:02:49 +0200 (MEST) Received: from curry.mchp.siemens.de (curry.mchp.siemens.de [139.25.42.7]) 1.46 2003/05/28 09:28:32 ust Exp $) with ESMTP id h8UB2niR072582 for ; Tue, 30 Sep 2003 13:02:49 +0200 (CEST) Received: (from localhost) by curry.mchp.siemens.de (8.12.9/8.12.9) id h8UB2nhE052202 for FreeBSD-gnats-submit@freebsd.org; Tue, 30 Sep 2003 13:02:49 +0200 (CEST) Message-Id: <200309301102.h8UB2nS7010685@curry.mchp.siemens.de> Date: Tue, 30 Sep 2003 13:02:49 +0200 (CEST) From: Andre Albsmeier To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: bin/57401: amd sets wrong permissions on mount point for msdosfs X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Sep 2003 11:10:22 -0000 >Number: 57401 >Category: bin >Synopsis: amd sets wrong permissions on mount point for msdosfs >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Sep 30 04:10:20 PDT 2003 >Closed-Date: >Last-Modified: >Originator: Andre Albsmeier >Release: FreeBSD 4.8-STABLE i386 >Organization: >Environment: System: FreeBSD 4.8-STABLE >Description: In august, the -M mask option for msdosfs was added: http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/msdosfs/Attic/msdosfsmount.h amd doesn't know about the new mode_t dirmask which results in the mountpoint having wrong permissions: d--------- 1 root wheel arch 7168 31 Dez 1979 /A/floppy/ >How-To-Repeat: Configure amd to mount a msdos fs automatically and check the permissions of the resulting mountpoint. >Fix: Quick and dirty: --- contrib/amd/amd/ops_pcfs.c.ORI Tue Sep 30 12:29:49 2003 +++ contrib/amd/amd/ops_pcfs.c Tue Sep 30 12:54:14 2003 @@ -132,6 +132,7 @@ #ifdef HAVE_FIELD_PCFS_ARGS_T_MASK pcfs_args.mask = 0777; /* this may be the msdos file modes */ + pcfs_args.dirmask = 0777; #endif /* HAVE_FIELD_PCFS_ARGS_T_MASK */ #ifdef HAVE_FIELD_PCFS_ARGS_T_UID >Release-Note: >Audit-Trail: >Unformatted: