From owner-freebsd-perl@FreeBSD.ORG Tue Mar 29 09:06:57 2005 Return-Path: Delivered-To: freebsd-perl@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B18AD16A4CE; Tue, 29 Mar 2005 09:06:57 +0000 (GMT) Received: from plouf.absolight.net (plouf.absolight.net [193.30.224.136]) by mx1.FreeBSD.org (Postfix) with ESMTP id 32B0243D2D; Tue, 29 Mar 2005 09:06:57 +0000 (GMT) (envelope-from mat@FreeBSD.org) Received: from pouet.in.mat.cc (pouet.in.mat.cc [193.30.224.122]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by plouf.absolight.net (Postfix) with ESMTP id 77174A24058; Tue, 29 Mar 2005 11:06:55 +0200 (CEST) Date: Tue, 29 Mar 2005 11:06:51 +0200 From: Mathieu Arnold To: Yen-Ming Lee Message-ID: <7D393AB1D864EB0DD1FF100E@[192.168.1.5]> In-Reply-To: <20050329084451.D1F743EA124@utopia.leeym.com> References: <20050329084451.D1F743EA124@utopia.leeym.com> X-Mailer: Mulberry/4.0.0a5 (Win32) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline cc: perl@freebsd.org Subject: Re: [PATCH] devel/p5-Module-Build: add .packlist in PLIST X-BeenThere: freebsd-perl@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: maintainer of a number of perl-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Mar 2005 09:06:57 -0000 I know about that, and I've been thinking on it hard. Your PR is just about as inapropriate as possible :-) because, if you fix it this way, you'll have to fix every other package using Module::Build to build, because as it says it, "The default value is true" meaning that every other port will have this .packlist. The correct solution is either to use the previous version of the port for 5.4 release (or to back it out), or to add a create_packlist=false in the appropriate part of bsd.port.mk. +-Le 29/03/2005 16:44 +0800, Yen-Ming Lee a dit : | |> Submitter-Id: current-users |> Originator: Yen-Ming Lee |> Organization: FreeBSD Taiwan |> Confidential: no |> Synopsis: [PATCH] devel/p5-Module-Build: add .packlist in PLIST |> Severity: non-critical |> Priority: low |> Category: ports |> Class: change-request |> Release: FreeBSD 5.4-PRERELEASE i386 |> Environment: | System: FreeBSD utopia.leeym.com 5.4-PRERELEASE FreeBSD 5.4-PRERELEASE | #0: Tue Mar 15 10:20:57 CST 2005 |> Description: | - remove .packlist file which was introduced in Module::Build 0.2609 | | quoted from README | | create_packlist | If true, this parameter tells Module::Build to create a | .packlist file during the "install" action, just like | ExtUtils::MakeMaker does. The file is created in a | subdirectory of the "arch" installation location. It is used | by some other tools (CPAN, CPANPLUS, etc.) for determining | what files are part of an install. | | The default value is true. This parameter was introduced in | Module::Build version 0.2609; previously no packlists were | ever created by Module::Build. | | Port maintainer (mat@FreeBSD.org) is cc'd. | | Generated with FreeBSD Port Tools 0.63 |> How-To-Repeat: | | http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/e.5.2005032807/p5-M | odule-Build-0.26.09.log | |> Fix: | | --- p5-Module-Build-0.26.09.patch begins here --- | Index: pkg-plist | =================================================================== | RCS file: /home/pcvs/ports/devel/p5-Module-Build/pkg-plist,v | retrieving revision 1.8 | diff -u -u -r1.8 pkg-plist | --- pkg-plist 21 Mar 2005 14:59:46 -0000 1.8 | +++ pkg-plist 29 Mar 2005 08:41:31 -0000 | @@ -21,6 +21,10 @@ | %%SITE_PERL%%/Module/Build/Platform/darwin.pm | %%SITE_PERL%%/Module/Build/Platform/os2.pm | %%SITE_PERL%%/Module/Build/PodParser.pm | +%%SITE_PERL%%/%%PERL_ARCH%%/auto/Module/Build/.packlist | @dirrm %%SITE_PERL%%/Module/Build/Platform | @dirrm %%SITE_PERL%%/Module/Build | @unexec rmdir %D/%%SITE_PERL%%/Module 2>/dev/null || true | +@dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/Module/Build | +@unexec rmdir %D/%%SITE_PERL%%/%%PERL_ARCH%%/auto/Module/Build | 2>/dev/null || true +@unexec rmdir | %D/%%SITE_PERL%%/%%PERL_ARCH%%/auto/Module 2>/dev/null || true --- | p5-Module-Build-0.26.09.patch ends here --- | -- Mathieu Arnold