From owner-svn-src-head@FreeBSD.ORG Fri Jul 18 16:46:35 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2AE38EA1; Fri, 18 Jul 2014 16:46:35 +0000 (UTC) Received: from alto.onthenet.com.au (alto.OntheNet.com.au [203.13.68.12]) by mx1.freebsd.org (Postfix) with ESMTP id E26BA2735; Fri, 18 Jul 2014 16:46:34 +0000 (UTC) Received: from dommail.onthenet.com.au (dommail.OntheNet.com.au [203.13.70.57]) by alto.onthenet.com.au (Postfix) with ESMTPS id 260CE124F1; Sat, 19 Jul 2014 02:46:27 +1000 (EST) Received: from Peters-MacBook-Pro.local (c-67-161-27-37.hsd1.ca.comcast.net [67.161.27.37]) by dommail.onthenet.com.au (MOS 4.4.4-GA) with ESMTP id BXF02833 (AUTH peterg@ptree32.com.au); Sat, 19 Jul 2014 02:46:25 +1000 Message-ID: <53C94F61.5020706@freebsd.org> Date: Fri, 18 Jul 2014 09:46:25 -0700 From: Peter Grehan User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Adrian Chadd , svn-src-head@freebsd.org Subject: Re: svn commit: r268837 - head/sys/netinet References: <201407180822.s6I8MD5a023838@svn.freebsd.org> In-Reply-To: <201407180822.s6I8MD5a023838@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jul 2014 16:46:35 -0000 > Update the default RSS hash to the Chelsio T5 firmware one - it provides > markedly better distribution of IPv6 address/ports than the previous key. That's actually the key that's used for verification in the Microsoft spec, though it looks like you have the bytes arranged backwards, which appears to be an artifact of the strange way the key is programmed into the Chelsio. My suggestion is: put the bytes in the default key in the order they are in the spec. This allows independent verification of the hash function in hardware by injecting frames with the values from the spec and looking at what h/w provides. Then, fix how it is programmed in the Chelsio. From memory, the Intel registers were a byte array. I also recall that the Qlogic FCOE adapters were 32-bits at a time, but big-endian. On the contents of the has, so long as there are a enough random 1-bits in the key, the distribution is as good as the Jenkins hash. Easy to verify with a test harness and ministat etc, but also verified at Netapp in the mega performance lab with a number of different key values. later, Peter.